Replace GDataDirectory::TakeEntry with GDataDirectoryService::AddEntryToDirectory.

Replace GDataDirectory::TakeEntry with GDataDirectoryService::MoveEntryToDirectory.

* Replace FilePathUpdateCallback with FileMoveCallback, and move this typedef to gdata_files.h
* GDataDirectoryService::AddEntryToDirectory has been renamed to MoveEntryToDirectory, and now takes FileMoveCallback, and calls RemoveChild on the parent, as TakeEntry used to do. Also add a ui thread DCHECK and fix tests.
* Get rid of GDataDirectory::TakeEntry, replacing all invocations with GDataDirectoryService::MoveEntryToDirectory. 
* Introduce callbacks OnMoveEntryToDirectoryWithFileMoveCallback, and OnMoveEntryToDirectoryWithFileOperationCallback to call OnDirectoryChanged and run callbacks.
* Replace GDataFileSystem callbacks OnRenameResourceCompleted and OnRemoveEntryFromDirectoryCompleted with RenameFileOnFilesystem and RemoveEntryFromDirectoryOnFilesystem.
* Get rid of GDataFilesystem::AddEntryToDirectoryOnFilesystem.
* Make RemoveChildren, RemoveChildFiles, RemoveChildDirectories private.
* FromDocumentEntry should take parent NULL, as should GDataDirectory/GDataFile ctors. This will be more comprehensively fixed in a future patch. The fixes in this patch are necessary for unit tests.
* Replace FOR_EACH_OBSERVER(Observers OnDirectoryChanged) with OnDirectoryChanged, for brevity.
* Add gdata::test_util::CopyErrorCodeFromFileMoveCallback for gdata_files_unittest.

BUG=137725
TEST=unit tests, manual test moving files in the same directory and between directories.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150684

[achuithb, 2012-08-08 02:35:18]

Satoru-san, please review.

[satorux1, 2012-08-08 14:09:06]

Took a quick first look. I'll take a closer look.

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_files.cc (right):

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_files.cc:957: scoped_ptr<GDataFile> file(new
GDataFile(NULL, directory_service_));
so the parent parameter was unnecessary, because AddEntry() sets the parent. If
so, could you remove the first parameter?

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_files.h (right):

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_files.h:372: // Must be called on UI thread.
|callback| is called on the UI thread.
The semantics of the function seems to be changed. Could you update the comment?

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_files_unittest.cc (right):

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:40: GDataDirectory* dir =
new GDataDirectory(NULL, directory_service);
can you remove the first parameter?

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:49:
base::Bind(&OnAddEntryToDirectory, GDATA_FILE_OK));
Hmm, this looks trickier than the original code. callback is hard to follow for
me. More importantly, with the original code, it was easy to detect where the
test failed from the line number. With this new code, the line number is always
the same (line 32). This is not good.

[satorux1, 2012-08-08 16:04:10]

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2416: if
(util::GDataToGDataFileError(status) == GDATA_FILE_OK)
Previously, |callback| was called if != GDATA_FILE_OK. Is it ok not to call it?

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2620: void
GDataFileSystem::RenameFileOnFilesystem(
Filesystem -> FileSystem. could you rename while you are at it?

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_file_system.h (right):

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_file_system.h:510: void
OnAddEntryToDirectory2(const FileOperationCallback& callback,
This does not look like a good name. What about:

OnAddEntryToDirectoryWithFilePathUpdateCallback
OnAddEntryToDirectoryWithFileOperationCallback

[achuithb, 2012-08-08 22:08:41]

Please take a look

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2416: if
(util::GDataToGDataFileError(status) == GDATA_FILE_OK)
On 2012/08/08 16:04:10, satorux1 wrote:
> Previously, |callback| was called if != GDATA_FILE_OK. Is it ok not to call
it?

Thank you for catching this. I made this error in another place too. I've
reworked this code and got rid of these unnecessary callback function, directly
calling RenameFileOnFileSystem and RemoveEntryFromDirectoryOnFileSystem.

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2620: void
GDataFileSystem::RenameFileOnFilesystem(
On 2012/08/08 16:04:10, satorux1 wrote:
> Filesystem -> FileSystem. could you rename while you are at it?

Done.

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_file_system.h (right):

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_file_system.h:510: void
OnAddEntryToDirectory2(const FileOperationCallback& callback,
On 2012/08/08 16:04:10, satorux1 wrote:
> This does not look like a good name. What about:
> 
> OnAddEntryToDirectoryWithFilePathUpdateCallback
> OnAddEntryToDirectoryWithFileOperationCallback

Thanks for the suggestion. I didn't have the courage to come up with names that
long. Done.

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_files.cc (right):

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_files.cc:957: scoped_ptr<GDataFile> file(new
GDataFile(NULL, directory_service_));
On 2012/08/08 14:09:06, satorux1 wrote:
> so the parent parameter was unnecessary, because AddEntry() sets the parent.
If
> so, could you remove the first parameter?

I intend to, and it will be a fun patch, but I don't want to clutter this CL
with all those changes. Is the next one ok? I can add a TODO.

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_files.h (right):

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_files.h:372: // Must be called on UI thread.
|callback| is called on the UI thread.
On 2012/08/08 14:09:06, satorux1 wrote:
> The semantics of the function seems to be changed. Could you update the
comment?

I can update the comment to state that the entry is removed from the previous
parent. The prior implementation was buggy/incorrect - not removing from the
previous parent means the entry will eventually get double deleted. We weren't
running crashing before because this was only used in test code without a valid
parent.

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_files_unittest.cc (right):

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:40: GDataDirectory* dir =
new GDataDirectory(NULL, directory_service);
On 2012/08/08 14:09:06, satorux1 wrote:
> can you remove the first parameter?

In the next CL?

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:49:
base::Bind(&OnAddEntryToDirectory, GDATA_FILE_OK));
On 2012/08/08 14:09:06, satorux1 wrote:
> Hmm, this looks trickier than the original code. callback is hard to follow
for
> me. More importantly, with the original code, it was easy to detect where the
> test failed from the line number. With this new code, the line number is
always
> the same (line 32). This is not good.

Good point. I can't use CopyErrorCodeFromFileOperationCallback, so I'd need to
create something like CopyErrorCodeFromFilePathUpdateCallback. Is that what
you'd prefer?

[achuithb, 2012-08-08 22:38:00]

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_files_unittest.cc (right):

http://codereview.chromium.org/10827211/diff/9002/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:49:
base::Bind(&OnAddEntryToDirectory, GDATA_FILE_OK));
On 2012/08/08 22:08:41, achuith.bhandarkar wrote:
> On 2012/08/08 14:09:06, satorux1 wrote:
> > Hmm, this looks trickier than the original code. callback is hard to follow
> for
> > me. More importantly, with the original code, it was easy to detect where
the
> > test failed from the line number. With this new code, the line number is
> always
> > the same (line 32). This is not good.
> 
> Good point. I can't use CopyErrorCodeFromFileOperationCallback, so I'd need to
> create something like CopyErrorCodeFromFilePathUpdateCallback. Is that what
> you'd prefer?

I did this since I'm guessing you prefer this solution.

[satorux1, 2012-08-08 23:25:01]

looking at the code, you were modifying the most complicated code in
gdata_file_system.cc. Thank you for working on this grungy task! :)

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_file_system.cc:1195:
add_file_to_directory_callback);
wow, move operation is super complicated...

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2402: const FilePath&
file_path) {
this is weird. file_path is not used... can you comment out as /* file_path */ ?

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2629:
directory_service_->AddEntryToDirectory(entry->parent()->GetFilePath(), entry,
nit: when it cannot fit one line, let's align parameters vertically (sky@'s
way).

directory_service_->AddEntryToDirectory(
   entry->parent()->GetFilePath(),
   entry,
   base::Bind(...));

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2658:
directory_service_->root()->GetFilePath(), entry,
nit: move entry to the next line

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
File chrome/browser/chromeos/gdata/gdata_file_system.h (right):

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_file_system.h:354: // Renames a file or
directory at |file_path| to |new_name|.
While you are at it, could you add some documentation? To review your patch, I
needed to read the implementation to understand the semantics of the function.

// Renames a file or directory at |file_path| to |new_name|
// in the same directory. |callback| will receive the new
// file path if the operation is successful. If the new name
// already exists in the same directory, a unique name is given
// by adding a parenthesized serial number like "foo (2).txt".

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
File chrome/browser/chromeos/gdata/gdata_files.h (right):

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_files.h:77: // Callback similar to
FileOperationCallback but with a given |file_path|.
let's add:

// Used for operations that change a file path like moving files.

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_files.h:80: FilePathUpdateCallback;
Maybe FilePathChangeCallback?

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_files.h:378: GDataEntry* entry,
Not in this patch, but I think we should change this to take GDataEntryProto
instead.

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
File chrome/browser/chromeos/gdata/gdata_test_util.h (right):

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_test_util.h:49: void
CopyErrorCodeFromFilePathUpdateCallback(GDataFileError* output,
function comment is missing. |updated_file_path| seems to be ignored, but we
should probably copy it as well.

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_test_util.h:50: GDataFileError error, const
FilePath& updated_file_path);
could you list parameters vertically?

[satorux1, 2012-08-08 23:40:57]

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
File chrome/browser/chromeos/gdata/gdata_files.h (right):

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_files.h:80: FilePathUpdateCallback;
On 2012/08/08 23:25:01, satorux1 wrote:
> Maybe FilePathChangeCallback?

Better idea. This callback seems to be only used for moving files, if so
FileMoveCallback would be succinct and accurate.

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_files.h:375: // previous parent. Must be
called on UI thread. |callback| is called on the
Per the description, "MoveEntryToDirectory" may be a better name?

[achuithb, 2012-08-09 00:12:50]

I didn't change any code in the rebase, so you can ignore it. 

Also updated the CL description. PTAL.

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2402: const FilePath&
file_path) {
On 2012/08/08 23:25:01, satorux1 wrote:
> this is weird. file_path is not used... can you comment out as /* file_path */
?

Done.

We have this in a lot of places because we get callbacks with all kinds of
params that we don't care about. Many callback functions have unused params. I
don't think it's worth the time to fix these.

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2629:
directory_service_->AddEntryToDirectory(entry->parent()->GetFilePath(), entry,
On 2012/08/08 23:25:01, satorux1 wrote:
> nit: when it cannot fit one line, let's align parameters vertically (sky@'s
> way).
> 
> directory_service_->AddEntryToDirectory(
>    entry->parent()->GetFilePath(),
>    entry,
>    base::Bind(...));

Done.

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2658:
directory_service_->root()->GetFilePath(), entry,
On 2012/08/08 23:25:01, satorux1 wrote:
> nit: move entry to the next line

Done.

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
File chrome/browser/chromeos/gdata/gdata_file_system.h (right):

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_file_system.h:354: // Renames a file or
directory at |file_path| to |new_name|.
On 2012/08/08 23:25:01, satorux1 wrote:
> While you are at it, could you add some documentation? To review your patch, I
> needed to read the implementation to understand the semantics of the function.
> 
> // Renames a file or directory at |file_path| to |new_name|
> // in the same directory. |callback| will receive the new
> // file path if the operation is successful. If the new name
> // already exists in the same directory, a unique name is given
> // by adding a parenthesized serial number like "foo (2).txt".

Done.

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
File chrome/browser/chromeos/gdata/gdata_files.h (right):

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_files.h:77: // Callback similar to
FileOperationCallback but with a given |file_path|.
On 2012/08/08 23:25:01, satorux1 wrote:
> let's add:
> 
> // Used for operations that change a file path like moving files.

Done.

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_files.h:80: FilePathUpdateCallback;
On 2012/08/08 23:40:57, satorux1 wrote:
> On 2012/08/08 23:25:01, satorux1 wrote:
> > Maybe FilePathChangeCallback?
> 
> Better idea. This callback seems to be only used for moving files, if so
> FileMoveCallback would be succinct and accurate.

Done.

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_files.h:375: // previous parent. Must be
called on UI thread. |callback| is called on the
On 2012/08/08 23:40:58, satorux1 wrote:
> Per the description, "MoveEntryToDirectory" may be a better name?

Done.

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_files.h:378: GDataEntry* entry,
On 2012/08/08 23:25:01, satorux1 wrote:
> Not in this patch, but I think we should change this to take GDataEntryProto
> instead. 

Yup

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
File chrome/browser/chromeos/gdata/gdata_test_util.h (right):

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_test_util.h:49: void
CopyErrorCodeFromFilePathUpdateCallback(GDataFileError* output,
On 2012/08/08 23:25:01, satorux1 wrote:
> function comment is missing. |updated_file_path| seems to be ignored, but we
> should probably copy it as well.

Done.

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_test_util.h:50: GDataFileError error, const
FilePath& updated_file_path);
On 2012/08/08 23:25:01, satorux1 wrote:
> could you list parameters vertically?

Done.

[satorux1, 2012-08-09 00:26:24]

Could you also update the TEST= line? This change is big so I'd like you to
manually test that the file move operation works as before (rename in the same
directory, and move to another directory). I think you did it, but would be nice
to mention in TEST= line.

LGTM with suggestions for tests.

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10827211/diff/10/chrome/browser/chromeos/gdata...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2402: const FilePath&
file_path) {
On 2012/08/09 00:12:51, achuith.bhandarkar wrote:
> On 2012/08/08 23:25:01, satorux1 wrote:
> > this is weird. file_path is not used... can you comment out as /* file_path
*/
> ?
> 
> Done.
> 
> We have this in a lot of places because we get callbacks with all kinds of
> params that we don't care about. Many callback functions have unused params. I
> don't think it's worth the time to fix these.

don't have to spend time finding them but if we see some, let's fix them. it's
part of the style guide.

http://codereview.chromium.org/10827211/diff/3004/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_files_unittest.cc (right):

http://codereview.chromium.org/10827211/diff/3004/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:47:
EXPECT_EQ(GDATA_FILE_OK, error);
To test MoveEntryToDirectory better, I think we should check the new path name,
like

EXPECT_EQ(parent->GetFilePath().AppendASCII(dir_name), moved_path);

http://codereview.chromium.org/10827211/diff/3004/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:69:
EXPECT_EQ(GDATA_FILE_OK, error);
ditto, and elsewhere too.

http://codereview.chromium.org/10827211/diff/3004/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_test_util.h (right):

http://codereview.chromium.org/10827211/diff/3004/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_test_util.h:54: void
CopyErrorCodeFromFileMoveCallback(GDataFileError* output,
I think we should also copy the path. See my comments in the test.

http://codereview.chromium.org/10827211/diff/3004/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_test_util.h:56: const FilePath&
updated_file_path);
moved_file_path

[achuithb, 2012-08-09 01:41:32]

Thanks for the review!

http://codereview.chromium.org/10827211/diff/3004/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_files_unittest.cc (right):

http://codereview.chromium.org/10827211/diff/3004/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:47:
EXPECT_EQ(GDATA_FILE_OK, error);
On 2012/08/09 00:26:24, satorux1 wrote:
> To test MoveEntryToDirectory better, I think we should check the new path
name,
> like
> 
> EXPECT_EQ(parent->GetFilePath().AppendASCII(dir_name), moved_path);

Done.

http://codereview.chromium.org/10827211/diff/3004/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:69:
EXPECT_EQ(GDATA_FILE_OK, error);
On 2012/08/09 00:26:24, satorux1 wrote:
> ditto, and elsewhere too.

Done.

http://codereview.chromium.org/10827211/diff/3004/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_test_util.h (right):

http://codereview.chromium.org/10827211/diff/3004/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_test_util.h:54: void
CopyErrorCodeFromFileMoveCallback(GDataFileError* output,
On 2012/08/09 00:26:24, satorux1 wrote:
> I think we should also copy the path. See my comments in the test.

Done.

http://codereview.chromium.org/10827211/diff/3004/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_test_util.h:56: const FilePath&
updated_file_path);
On 2012/08/09 00:26:24, satorux1 wrote:
> moved_file_path

Replaced here and elsewhere.

[commit-bot: I haz the power, 2012-08-09 01:42:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/10827211/15

[satorux1, 2012-08-10 21:04:15]

https://chromiumcodereview.appspot.com/10827211/diff/15/chrome/browser/chrome...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (left):

https://chromiumcodereview.appspot.com/10827211/diff/15/chrome/browser/chrome...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2685: GDataEntry* dir =
directory_service_->FindEntryByPathSync(dir_path);
The two callers of FindEntryByPathSync() were removed. This is nice!