runtime/vm/stub_code_x64.cc - Issue 10832214: Move deopt reason into PcDescriptor so the EAX/RAX register is not destroyed. Some cleanups in PC d…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_x64.cc

Issue 10832214: Move deopt reason into PcDescriptor so the EAX/RAX register is not destroyed. Some cleanups in PC d… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stub_code_x64.cc

===================================================================

--- runtime/vm/stub_code_x64.cc (revision 10420)

+++ runtime/vm/stub_code_x64.cc (working copy)

@@ -579,7 +579,6 @@

// | optimized frame |

// | ... |

-// RAX: Deoptimization reason id.

void StubCode::GenerateDeoptimizeStub(Assembler* assembler) {

__ EnterFrame(0);

// Push registers in their enumeration order: lowest register number at

@@ -590,8 +589,7 @@

__ movq(RCX, RSP); // Saved saved registers block.

__ ReserveAlignedFrameSpace(0);

__ SmiUntag(RAX);

- __ movq(RDI, RAX); // Set up argument 1 deopt_reason.

- __ movq(RSI, RCX); // Set up argument 2 saved_registers_address.

+ __ movq(RDI, RCX); // Set up argument 1 saved_registers_address.

__ CallRuntime(kDeoptimizeCopyFrameRuntimeEntry);

// Result (RAX) is stack-size (FP - SP) in bytes, incl. the return address.

« no previous file with comments | « runtime/vm/stub_code_ia32.cc ('k') | no next file » | no next file with comments »