Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1854)

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 10832214: Move deopt reason into PcDescriptor so the EAX/RAX register is not destroyed. Some cleanups in PC d… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_ia32.cc
===================================================================
--- runtime/vm/stub_code_ia32.cc (revision 10420)
+++ runtime/vm/stub_code_ia32.cc (working copy)
@@ -586,7 +586,6 @@
// | optimized frame |
// | ... |
//
-// EAX: Deoptimization reason id.
void StubCode::GenerateDeoptimizeStub(Assembler* assembler) {
__ EnterFrame(0);
// Push registers in their enumeration order: lowest register number at
@@ -595,10 +594,9 @@
__ pushl(static_cast<Register>(i));
}
__ movl(ECX, ESP); // Saved saved registers block.
- __ ReserveAlignedFrameSpace(2 * kWordSize);
+ __ ReserveAlignedFrameSpace(1 * kWordSize);
__ SmiUntag(EAX);
- __ movl(Address(ESP, 0), EAX); // Deopt reason (untagged).
- __ movl(Address(ESP, kWordSize), ECX); // Start of register block.
+ __ movl(Address(ESP, 0), ECX); // Start of register block.
__ CallRuntime(kDeoptimizeCopyFrameRuntimeEntry);
// Result (EAX) is stack-size (FP - SP) in bytes, incl. the return address.
__ LeaveFrame();
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698