Issue 10832193: fix broken windows build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832193: fix broken windows build (Closed)

Created:
8 years, 4 months ago by scottmg

Modified:
8 years, 4 months ago

Reviewers:
pkotwicz, sky

CC:
chromium-reviews, tfarina

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

fix broken windows build browser.app_panel_browser_frame_view.obj : error LNK2001: unresolved external symbol "public: virtual int __thiscall AppPanelBrowserFrameView::GetThemeBackgroundXInset(void)const " (?GetThemeBackgroundXInset@AppPanelBrowserFrameView@@UBEHXZ) initial\chrome.dll : fatal error LNK1120: 1 unresolved externals ninja: build stopped: subcommand failed. See https://chromiumcodereview.appspot.com/10816004 Maybe only failing on component build? Not sure. R=pkotwicz@chromium.org,sky@chromium.org BUG=137090 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150437

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/ui/views/frame/app_panel_browser_frame_view.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

LGTM