Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 10816004: Fixes missing 5 pixel inset for theme background in Ash (Closed)

Created:
8 years, 5 months ago by pkotwicz
Modified:
8 years, 4 months ago
Reviewers:
DaveMoore, sky
CC:
chromium-reviews, jennb, sadrul, ben+watch_chromium.org, Dmitry Titov, jianli, dcheng
Visibility:
Public.

Description

Fixes missing 5 pixel inset for inactive tab theme background and theme background for new tab button in Ash. The theme background is correctly inset by 5 pixels. In frame_painter.cc Added GetThemeBackgroundXInset such that the x inset can be queried. BUG=137090 TEST=Inactive tab theme background lines up for "Kate Spades", "Quilt", and "Wooded Chrome Theme by Everplex" with theme background for toolbar. In particular, "Wooded Chrome Theme By Everplex" should behave the same way it does on Mac and Windows. So, the theme should NOT line up with the NTP image. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150354

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -13 lines) Patch
M ash/wm/frame_painter.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ash/wm/frame_painter.cc View 1 2 6 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/app_non_client_frame_view_aura.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/app_non_client_frame_view_aura.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/app_panel_browser_frame_view.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/popup_non_client_frame_view.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/popup_non_client_frame_view.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
pkotwicz
Finally got to this.
8 years, 5 months ago (2012-07-20 15:10:52 UTC) #1
pkotwicz
Ping!
8 years, 5 months ago (2012-07-26 00:44:01 UTC) #2
DaveMoore
lgtm
8 years, 4 months ago (2012-07-27 14:24:44 UTC) #3
pkotwicz
sky for OWNERS
8 years, 4 months ago (2012-07-27 16:24:34 UTC) #4
sky
LGTM
8 years, 4 months ago (2012-08-02 20:41:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10816004/2001
8 years, 4 months ago (2012-08-05 19:33:55 UTC) #6
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/panels/panel_browser_frame_view.h: While running patch -p1 --forward --force; patching file chrome/browser/ui/panels/panel_browser_frame_view.h ...
8 years, 4 months ago (2012-08-05 19:34:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10816004/20002
8 years, 4 months ago (2012-08-05 19:41:05 UTC) #8
commit-bot: I haz the power
Try job failure for 10816004-20002 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-05 20:31:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10816004/10022
8 years, 4 months ago (2012-08-05 20:45:00 UTC) #10
commit-bot: I haz the power
Try job failure for 10816004-10022 (retry) (retry) on win_rel for step "compile" (clobber build). It's ...
8 years, 4 months ago (2012-08-05 21:14:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10816004/18024
8 years, 4 months ago (2012-08-06 00:16:23 UTC) #12
commit-bot: I haz the power
Try job failure for 10816004-18024 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 00:39:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10816004/18024
8 years, 4 months ago (2012-08-06 22:04:30 UTC) #14
commit-bot: I haz the power
Try job failure for 10816004-18024 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 22:49:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10816004/18024
8 years, 4 months ago (2012-08-07 14:30:47 UTC) #16
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 15:52:22 UTC) #17
Change committed as 150354

Powered by Google App Engine
This is Rietveld 408576698