Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: webkit/glue/resource_type.h

Issue 10832138: Warn hackers that ResourceType is reported in histograms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/resource_type.h
diff --git a/webkit/glue/resource_type.h b/webkit/glue/resource_type.h
index 34dd12cfb78bb90f8cce82c0953fc20174a11f0b..85a59869cfa41785e667e14716454af6e688bca0 100644
--- a/webkit/glue/resource_type.h
+++ b/webkit/glue/resource_type.h
@@ -11,6 +11,8 @@
class ResourceType {
public:
+ // Used in histograms, so please add new types at the end, and rename unused
+ // entries to RESOURCETYPE_UNUSED_0, etc...
enum Type {
MAIN_FRAME = 0, // top level page
SUB_FRAME, // frame or iframe
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698