Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Side by Side Diff: webkit/glue/resource_type.h

Issue 10832138: Warn hackers that ResourceType is reported in histograms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_GLUE_RESOURCE_TYPE_H__ 5 #ifndef WEBKIT_GLUE_RESOURCE_TYPE_H__
6 #define WEBKIT_GLUE_RESOURCE_TYPE_H__ 6 #define WEBKIT_GLUE_RESOURCE_TYPE_H__
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebURLReques t.h" 9 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebURLReques t.h"
10 #include "webkit/glue/webkit_glue_export.h" 10 #include "webkit/glue/webkit_glue_export.h"
11 11
12 class ResourceType { 12 class ResourceType {
13 public: 13 public:
14 // Used in histograms, so please add new types at the end, and rename unused
15 // entries to RESOURCETYPE_UNUSED_0, etc...
14 enum Type { 16 enum Type {
15 MAIN_FRAME = 0, // top level page 17 MAIN_FRAME = 0, // top level page
16 SUB_FRAME, // frame or iframe 18 SUB_FRAME, // frame or iframe
17 STYLESHEET, // a CSS stylesheet 19 STYLESHEET, // a CSS stylesheet
18 SCRIPT, // an external script 20 SCRIPT, // an external script
19 IMAGE, // an image (jpg/gif/png/etc) 21 IMAGE, // an image (jpg/gif/png/etc)
20 FONT_RESOURCE, // a font 22 FONT_RESOURCE, // a font
21 SUB_RESOURCE, // an "other" subresource. 23 SUB_RESOURCE, // an "other" subresource.
22 OBJECT, // an object (or embed) tag for a plugin, 24 OBJECT, // an object (or embed) tag for a plugin,
23 // or a resource that a plugin requested. 25 // or a resource that a plugin requested.
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 type == WORKER || 61 type == WORKER ||
60 type == XHR; 62 type == XHR;
61 } 63 }
62 64
63 private: 65 private:
64 // Don't instantiate this class. 66 // Don't instantiate this class.
65 ResourceType(); 67 ResourceType();
66 ~ResourceType(); 68 ~ResourceType();
67 }; 69 };
68 #endif // WEBKIT_GLUE_RESOURCE_TYPE_H__ 70 #endif // WEBKIT_GLUE_RESOURCE_TYPE_H__
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698