Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 10832138: Warn hackers that ResourceType is reported in histograms. (Closed)

Created:
8 years, 4 months ago by gavinp
Modified:
8 years, 4 months ago
Reviewers:
jamesr, frankwang
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Warn hackers that ResourceType is reported in histograms. See https://chromiumcodereview.appspot.com/10701151 for our first ResourceType histogram. R=jamesr@chromium.org,frankwang@google.com BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150412

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webkit/glue/resource_type.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gavinp
WDYT?
8 years, 4 months ago (2012-08-03 17:01:53 UTC) #1
frankwang
lgtm
8 years, 4 months ago (2012-08-03 17:06:12 UTC) #2
gavinp
On 2012/08/03 17:06:12, frankwang wrote: > lgtm jamesr, wdyt?
8 years, 4 months ago (2012-08-07 15:34:35 UTC) #3
jamesr
lgtm
8 years, 4 months ago (2012-08-07 19:22:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/10832138/1
8 years, 4 months ago (2012-08-07 19:22:41 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 21:17:49 UTC) #6
Change committed as 150412

Powered by Google App Engine
This is Rietveld 408576698