Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: content/public/browser/favicon_status.h

Issue 10832128: Convert FaviconStatus::bitmap from SkBitmap to gfx::Image. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tests? Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/toolbar/back_forward_menu_model.cc ('k') | content/public/browser/favicon_status.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/favicon_status.h
diff --git a/content/public/browser/favicon_status.h b/content/public/browser/favicon_status.h
index 6d5a8792135f83c85419262c5fcf8443ca739365..0899169db9b39d281df5e27ad53697b60e074ee4 100644
--- a/content/public/browser/favicon_status.h
+++ b/content/public/browser/favicon_status.h
@@ -7,6 +7,7 @@
#include "content/common/content_export.h"
#include "googleurl/src/gurl.h"
+#include "ui/gfx/image/image.h"
#include "third_party/skia/include/core/SkBitmap.h"
namespace content {
@@ -26,7 +27,10 @@ struct CONTENT_EXPORT FaviconStatus {
// set or it empty, it will return the default favicon. Note that this is
// loaded asynchronously, so even if the favicon URL is valid we may return
// the default favicon if we haven't gotten the data yet.
- SkBitmap bitmap;
+ gfx::Image image;
+
+ // Returns 1x resolution of image. This function should eventually go away.
sky 2012/08/03 17:17:59 move above fields.
+ SkBitmap AsBitmap() const;
// Copy and assignment is explicitly allowed for this struct.
};
« no previous file with comments | « chrome/browser/ui/toolbar/back_forward_menu_model.cc ('k') | content/public/browser/favicon_status.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698