Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Side by Side Diff: content/public/browser/favicon_status.h

Issue 10832128: Convert FaviconStatus::bitmap from SkBitmap to gfx::Image. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tests? Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_FAVICON_STATUS_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_FAVICON_STATUS_H_
6 #define CONTENT_PUBLIC_BROWSER_FAVICON_STATUS_H_ 6 #define CONTENT_PUBLIC_BROWSER_FAVICON_STATUS_H_
7 7
8 #include "content/common/content_export.h" 8 #include "content/common/content_export.h"
9 #include "googleurl/src/gurl.h" 9 #include "googleurl/src/gurl.h"
10 #include "ui/gfx/image/image.h"
10 #include "third_party/skia/include/core/SkBitmap.h" 11 #include "third_party/skia/include/core/SkBitmap.h"
11 12
12 namespace content { 13 namespace content {
13 14
14 // Collects the favicon related information for a NavigationEntry. 15 // Collects the favicon related information for a NavigationEntry.
15 struct CONTENT_EXPORT FaviconStatus { 16 struct CONTENT_EXPORT FaviconStatus {
16 FaviconStatus(); 17 FaviconStatus();
17 18
18 // Indicates whether we've gotten an official favicon for the page, or are 19 // Indicates whether we've gotten an official favicon for the page, or are
19 // just using the default favicon. 20 // just using the default favicon.
20 bool valid; 21 bool valid;
21 22
22 // The URL of the favicon which was used to load it off the web. 23 // The URL of the favicon which was used to load it off the web.
23 GURL url; 24 GURL url;
24 25
25 // The favicon bitmap for the page. If the favicon has not been explicitly 26 // The favicon bitmap for the page. If the favicon has not been explicitly
26 // set or it empty, it will return the default favicon. Note that this is 27 // set or it empty, it will return the default favicon. Note that this is
27 // loaded asynchronously, so even if the favicon URL is valid we may return 28 // loaded asynchronously, so even if the favicon URL is valid we may return
28 // the default favicon if we haven't gotten the data yet. 29 // the default favicon if we haven't gotten the data yet.
29 SkBitmap bitmap; 30 gfx::Image image;
31
32 // Returns 1x resolution of image. This function should eventually go away.
sky 2012/08/03 17:17:59 move above fields.
33 SkBitmap AsBitmap() const;
30 34
31 // Copy and assignment is explicitly allowed for this struct. 35 // Copy and assignment is explicitly allowed for this struct.
32 }; 36 };
33 37
34 } // namespace content 38 } // namespace content
35 39
36 #endif // CONTENT_PUBLIC_BROWSER_FAVICON_STATUS_H_ 40 #endif // CONTENT_PUBLIC_BROWSER_FAVICON_STATUS_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/toolbar/back_forward_menu_model.cc ('k') | content/public/browser/favicon_status.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698