Issue 10832128: Convert FaviconStatus::bitmap from SkBitmap to gfx::Image.

Issue 10832128: Convert FaviconStatus::bitmap from SkBitmap to gfx::Image. (Closed)

Created:
8 years, 4 months ago by Nico

Modified:
8 years, 4 months ago

Reviewers:
sky, Jói

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, sreeram, pkotwicz

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Convert FaviconStatus::bitmap from SkBitmap to gfx::Image. Also rename it to "image". No intended behavior change. Part of supporting hidpi favicons in the tab strip. BUG=138550 TBR=joi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149874

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : bots #

Patch Set 4 : tests? #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -20 lines)			Patch
M	chrome/browser/debugger/devtools_window.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/favicon/favicon_handler.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/favicon/favicon_handler_unittest.cc	View	1 2	6 chunks	+10 lines, -7 lines	0 comments	Download
M	chrome/browser/favicon/favicon_tab_helper.cc	View	1 2 3	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/instant/instant_loader.cc	View	1 2 3	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/toolbar/back_forward_menu_model.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	content/public/browser/favicon_status.h	View	1 2 3	2 chunks	+5 lines, -1 line	1 comment	Download
M	content/public/browser/favicon_status.cc	View	1 2 3	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://chromiumcodereview.appspot.com/10832128/diff/13001/content/public/browser/favicon_status.h File content/public/browser/favicon_status.h (right): https://chromiumcodereview.appspot.com/10832128/diff/13001/content/public/browser/favicon_status.h#newcode32 content/public/browser/favicon_status.h:32: // Returns 1x resolution of image. This function ...

8 years, 4 months ago (2012-08-03 17:17:59 UTC) #2

Nico

+joi for OWNERS. TBRing as it's a trivial change and I have an lg from ...

8 years, 4 months ago (2012-08-03 18:15:37 UTC) #3

Jói

8 years, 4 months ago (2012-08-03 18:53:32 UTC) #4

LGTM for content/public.
On Aug 3, 2012 6:15 PM, <thakis@chromium.org> wrote:

> +joi for OWNERS. TBRing as it's a trivial change and I have an lg from sky.
>
>
https://chromiumcodereview.**appspot.com/10832128/<https://chromiumcodereview...
>

Expand Messages | Collapse Messages