Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 10832110: Docs: Clarifying the CSP-friendly replacement for <body onload="XXX">. (Closed)

Created:
8 years, 4 months ago by Mike West
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Docs: Clarifying the CSP-friendly replacement for <body onload="XXX">. BUG=140185 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152121

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebuilt. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -29 lines) Patch
M chrome/common/extensions/docs/extensions/contentSecurityPolicy.html View 1 3 chunks +20 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/server2/templates/articles/contentSecurityPolicy.html View 1 3 chunks +22 lines, -10 lines 0 comments Download
M chrome/common/extensions/docs/static/contentSecurityPolicy.html View 1 3 chunks +22 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mike West
This CL clarifies the replacement for <body onload="XXX"> in the brave new world of CSP. ...
8 years, 4 months ago (2012-08-02 09:13:30 UTC) #1
Mike West
Friendly ping. :) On 2012/08/02 09:13:30, Mike West (chromium) wrote: > This CL clarifies the ...
8 years, 4 months ago (2012-08-06 11:50:11 UTC) #2
Aaron Boodman
lgtm, one suggestion, don't need to wait for an additional review. http://codereview.chromium.org/10832110/diff/1/chrome/common/extensions/docs/static/contentSecurityPolicy.html File chrome/common/extensions/docs/static/contentSecurityPolicy.html (right): ...
8 years, 4 months ago (2012-08-10 19:21:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/10832110/1
8 years, 4 months ago (2012-08-16 14:44:49 UTC) #4
commit-bot: I haz the power
Presubmit check for 10832110-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-16 14:44:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/10832110/3002
8 years, 4 months ago (2012-08-17 12:36:15 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 18:43:32 UTC) #7
Change committed as 152121

Powered by Google App Engine
This is Rietveld 408576698