| Index: chrome/common/extensions/docs/extensions/contentSecurityPolicy.html
|
| diff --git a/chrome/common/extensions/docs/extensions/contentSecurityPolicy.html b/chrome/common/extensions/docs/extensions/contentSecurityPolicy.html
|
| index e55979bbbe9108d27fee8dcd5e2fe567d4e3f155..6ac5fe563a20ba00aa297c958be2a2b0587124d3 100644
|
| --- a/chrome/common/extensions/docs/extensions/contentSecurityPolicy.html
|
| +++ b/chrome/common/extensions/docs/extensions/contentSecurityPolicy.html
|
| @@ -297,9 +297,12 @@
|
| function clickHandler(element) {
|
| setTimeout(<strong>"awesome(); totallyAwesome()"</strong>, 1000);
|
| }
|
| + function main() {
|
| + // Initialization work goes here.
|
| + }
|
| </script>
|
| </head>
|
| - <body>
|
| + <body onload="main();">
|
| <button <strong>onclick="clickHandler(this)"</strong>>
|
| Click for awesomeness!
|
| </button>
|
| @@ -315,8 +318,13 @@
|
| JavaScript file (<code>popup.js</code> would be a good target).
|
| </li>
|
| <li>
|
| - The inline event handler definition must be rewritten in terms of
|
| - <code>addEventListener</code> and extracted into <code>popup.js</code>.
|
| + <p>The inline event handler definitions must be rewritten in terms of
|
| + <code>addEventListener</code> and extracted into <code>popup.js</code>.</p>
|
| + <p>If you're currently kicking off your program's execution via code like
|
| + <code><body onload="main();"></code>, consider replacing it by hooking
|
| + into the document's <code>DOMContentLoaded</code> event, or the window's
|
| + <code>load</code> event, depending on your needs. Below we'll use the
|
| + former, as it generally triggers more quickly.</p>
|
| </li>
|
| <li>
|
| The <code>setTimeout</code> call will need to be rewritten to avoid
|
| @@ -335,22 +343,25 @@ function awesome() {
|
| function totallyAwesome() {
|
| // do something TOTALLY awesome!
|
| }
|
| -<strong>
|
| -function awesomeTask() {
|
| +<strong>function awesomeTask() {
|
| awesome();
|
| totallyAwesome();
|
| -}
|
| -</strong>
|
| +}</strong>
|
| function clickHandler(e) {
|
| setTimeout(<strong>awesomeTask</strong>, 1000);
|
| }
|
| +function main() {
|
| + // Initialization work goes here.
|
| +}
|
| // Add event listeners once the DOM has fully loaded by listening for the
|
| // `DOMContentLoaded` event on the document, and adding your listeners to
|
| // specific elements when it triggers.
|
| -document.addEventListener('DOMContentLoaded', function () {
|
| +<strong>document.addEventListener('DOMContentLoaded', function () {</strong>
|
| document.querySelector('button').addEventListener('click', clickHandler);
|
| + main();
|
| });
|
| -popup.html:
|
| +</pre>
|
| +<pre>popup.html:
|
| ===========
|
| <!doctype html>
|
| <html>
|
|
|
Chromium Code Reviews
Issue 10832110:
Docs: Clarifying the CSP-friendly replacement for <body onload="XXX">. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src