Simplify the EC signature creation code by moving it to a Helper.

net/spdy/spdy_test_util_spdy3.h

Index: net/spdy/spdy_test_util_spdy3.h
diff --git a/net/spdy/spdy_test_util_spdy3.h b/net/spdy/spdy_test_util_spdy3.h
index 5b7b56a314c8e545ed8e682eeb9f25ed0caf7025..b27040fda154c31c7a270cd6ff4497eccb8362b3 100644
--- a/net/spdy/spdy_test_util_spdy3.h
+++ b/net/spdy/spdy_test_util_spdy3.h
@@ -6,6 +6,7 @@
 #define NET_SPDY_SPDY_TEST_UTIL_H_
 
 #include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
 #include "net/base/cert_verifier.h"
 #include "net/base/host_port_pair.h"
 #include "net/base/mock_host_resolver.h"
@@ -22,6 +23,10 @@
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_context_storage.h"
 
+namespace crypto {
+class ECSignatureCreatorFactory;
+}
+
 namespace net {
 
 namespace test_spdy3 {
@@ -422,6 +427,11 @@ class SpdyTestStateHelper {
   ~SpdyTestStateHelper();
 
  private:
+  // In order to make CREDENTIAL frame creation deterministic, we need to
+  // use a mock EC signature creator, which needs to live throughout
+  // the life of the test
+  scoped_ptr<crypto::ECSignatureCreatorFactory> ec_signature_creator_factory_;

[ramant (doing other things), 2012/08/01 17:01:58]

overly nit: punctuation.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Punctu...

[Ryan Hamilton, 2012/08/01 18:03:22]

Done.  (Assuming you want a period on 432, not a code change on 433)

+
   DISALLOW_COPY_AND_ASSIGN(SpdyTestStateHelper);
 };