Simplify the EC signature creation code by moving it to a Helper.

net/spdy/spdy_test_util_spdy3.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SPDY_SPDY_TEST_UTIL_H_
 #define NET_SPDY_SPDY_TEST_UTIL_H_
 
 #include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
 #include "net/base/cert_verifier.h"
 #include "net/base/host_port_pair.h"
 #include "net/base/mock_host_resolver.h"
 #include "net/base/request_priority.h"
 #include "net/base/ssl_config_service_defaults.h"
 #include "net/http/http_auth_handler_factory.h"
 #include "net/http/http_cache.h"
 #include "net/http/http_network_session.h"
 #include "net/http/http_network_layer.h"
 #include "net/http/http_server_properties_impl.h"
 #include "net/http/http_transaction_factory.h"
 #include "net/proxy/proxy_service.h"
 #include "net/socket/socket_test_util.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_context_storage.h"
 
+namespace crypto {
+class ECSignatureCreatorFactory;
+}
+
 namespace net {
 
 namespace test_spdy3 {
 
 // Default upload data used by both, mock objects and framer when creating
 // data frames.
 const char kDefaultURL[] = "http://www.google.com";
 const char kUploadData[] = "hello!";
 const int kUploadDataSize = arraysize(kUploadData)-1;
 
@@ skipping 380 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(SpdySessionPoolPeer);
 };
 
 // Helper to manage the state of a number of SPDY global variables.
 class SpdyTestStateHelper {
  public:
   SpdyTestStateHelper();
   ~SpdyTestStateHelper();
 
  private:
+  // In order to make CREDENTIAL frame creation deterministic, we need to
+  // use a mock EC signature creator, which needs to live throughout
+  // the life of the test
+  scoped_ptr<crypto::ECSignatureCreatorFactory> ec_signature_creator_factory_;

[ramant (doing other things), 2012/08/01 17:01:58]

overly nit: punctuation.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Punctu...

[Ryan Hamilton, 2012/08/01 18:03:22]

Done.  (Assuming you want a period on 432, not a code change on 433)

+
   DISALLOW_COPY_AND_ASSIGN(SpdyTestStateHelper);
 };
 
 }  // namespace test_spdy3
 
 }  // namespace net
 
 #endif  // NET_SPDY_SPDY_TEST_UTIL_H_