Simplify the EC signature creation code by moving it to a Helper.

Simplify the EC signature creation code by moving it to a Helper.

BUG=139700
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149461

[Ryan Hamilton, 2012-08-01 16:06:12]

Hi Raman, 

Can you take a look?  This is a pretty minor refactoring of some test code in
advance of landing Channel ID support in CREDENTIAL frames.

[ramant (doing other things), 2012-08-01 17:01:58]

lgtm

https://chromiumcodereview.appspot.com/10832098/diff/1/net/spdy/spdy_test_uti...
File net/spdy/spdy_test_util_spdy3.cc (right):

https://chromiumcodereview.appspot.com/10832098/diff/1/net/spdy/spdy_test_uti...
net/spdy/spdy_test_util_spdy3.cc:1048:
crypto::ECSignatureCreator::SetFactoryForTesting(
overly nit: punctuation.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Punctu...

https://chromiumcodereview.appspot.com/10832098/diff/1/net/spdy/spdy_test_uti...
File net/spdy/spdy_test_util_spdy3.h (right):

https://chromiumcodereview.appspot.com/10832098/diff/1/net/spdy/spdy_test_uti...
net/spdy/spdy_test_util_spdy3.h:433:
scoped_ptr<crypto::ECSignatureCreatorFactory> ec_signature_creator_factory_;
overly nit: punctuation.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Punctu...

[Ryan Hamilton, 2012-08-01 18:03:22]

Thanks!

https://chromiumcodereview.appspot.com/10832098/diff/1/net/spdy/spdy_test_uti...
File net/spdy/spdy_test_util_spdy3.cc (right):

https://chromiumcodereview.appspot.com/10832098/diff/1/net/spdy/spdy_test_uti...
net/spdy/spdy_test_util_spdy3.cc:1048:
crypto::ECSignatureCreator::SetFactoryForTesting(
On 2012/08/01 17:01:58, ramant wrote:
> overly nit: punctuation.
> 
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Punctu...

Done.  (I assume you want me to add a period to the comment on line 1047, not to
change something about the code on line 1048.)

https://chromiumcodereview.appspot.com/10832098/diff/1/net/spdy/spdy_test_uti...
File net/spdy/spdy_test_util_spdy3.h (right):

https://chromiumcodereview.appspot.com/10832098/diff/1/net/spdy/spdy_test_uti...
net/spdy/spdy_test_util_spdy3.h:433:
scoped_ptr<crypto::ECSignatureCreatorFactory> ec_signature_creator_factory_;
On 2012/08/01 17:01:58, ramant wrote:
> overly nit: punctuation.
> 
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Punctu...

Done.  (Assuming you want a period on 432, not a code change on 433)

[commit-bot: I haz the power, 2012-08-01 18:03:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/10832098/5002

[commit-bot: I haz the power, 2012-08-01 19:27:20]

Change committed as 149461