Moving Windows-only files: remoting/host -> remoting/host/win.

Moving Windows-only files: remoting/host -> remoting/host/win.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149043

[alexeypa (please no reviews), 2012-07-30 19:29:07]

Please take a look.

This CL only moves the files and removes unnecessary Win suffix from several
class names.

[simonmorris, 2012-07-30 20:38:55]

I think other team members should say whether they think this would be a good
idea.

It's inconsistent with our practice for Mac/Linux, but maybe we should tidy
those up similarly?

Shouldn't there be changes to remoting.gyp in this CL?

[alexeypa (please no reviews), 2012-07-30 21:00:52]

On 2012/07/30 20:38:55, simonmorris wrote:
> I think other team members should say whether they think this would be a good
> idea.

I talks about it with Wez briefly. He was OK with the idea. +Jamie

> It's inconsistent with our practice for Mac/Linux, but maybe we should tidy
> those up similarly?

This CL does not touch Windows-specific implementations of cross-platform files.
Clipboard is a good example of what is not moved. There are very few Mac- and
Linux- only files that fall into this category.

> Shouldn't there be changes to remoting.gyp in this CL?

Yeah, that would be a nice idea. :-) Thanks.

[alexeypa (please no reviews), 2012-07-30 21:01:34]

On 2012/07/30 21:00:52, alexeypa wrote:
> I talks about ...

:-( "I talked about ..."

[Lambros, 2012-07-30 21:06:28]

On 2012/07/30 20:38:55, simonmorris wrote:
> I think other team members should say whether they think this would be a good
> idea.
> 
> It's inconsistent with our practice for Mac/Linux, but maybe we should tidy
> those up similarly?
This is fine by me.  We could do something similar with the Mac pref-pane stuff.

[Jamie, 2012-07-30 21:26:39]

I'm all for grouping platforms by directory rather than by filename. Do we still
get gyp filtering for free (like we do with _win suffixes)?

[Sergey Ulanov, 2012-07-30 21:28:00]

Moving these files to a separate dir is a reasonable thing to do. The code that
implements cross-platform interfaces should still stay in a directory shared
between all platforms. I think it would make sense to do the same for mac and
linux. E.g. all OSX preferences panel stuff belongs to a separate mac directory.

On 2012/07/30 20:38:55, simonmorris wrote:
> I think other team members should say whether they think this would be a good
> idea.
> 
> It's inconsistent with our practice for Mac/Linux, but maybe we should tidy
> those up similarly?
> 
> Shouldn't there be changes to remoting.gyp in this CL?

[alexeypa (please no reviews), 2012-07-30 21:28:10]

On 2012/07/30 21:26:39, Jamie wrote:
> Do we still get gyp filtering for free (like we do with _win suffixes)?

Yes.

[Lambros (do not use), 2012-07-30 21:30:39]

On Mon, Jul 30, 2012 at 2:28 PM, <sergeyu@chromium.org> wrote:

> Moving these files to a separate dir is a reasonable thing to do. The code
> that
> implements cross-platform interfaces should still stay in a directory
> shared
> between all platforms.

+1

[alexeypa (please no reviews), 2012-07-30 21:32:37]

On 2012/07/30 21:30:39, lambroslambrou wrote:
> On Mon, Jul 30, 2012 at 2:28 PM, <mailto:sergeyu@chromium.org> wrote:
> 
> > Moving these files to a separate dir is a reasonable thing to do. The code
> > that
> > implements cross-platform interfaces should still stay in a directory
> > shared
> > between all platforms.
> 
> +1

Let's make it in a separate CL though. Unless someone lends me a Mac. :-)

[simonmorris, 2012-07-30 21:34:35]

lgtm

[commit-bot: I haz the power, 2012-07-30 21:45:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10832068/11004

[commit-bot: I haz the power, 2012-07-30 21:45:23]

Failed to apply patch for remoting/host/win/desktop.cc:
While running patch -p0 --forward --force;
A         remoting/host/win
patching file remoting/host/win/desktop.cc
Hunk #1 FAILED at 2.
Hunk #2 FAILED at 10.
Hunk #3 FAILED at 22.
Hunk #4 FAILED at 43.
Hunk #5 FAILED at 55.
Hunk #6 FAILED at 65.
Hunk #7 FAILED at 74.
7 out of 7 hunks FAILED -- saving rejects to file
remoting/host/win/desktop.cc.rej

[commit-bot: I haz the power, 2012-07-30 21:58:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10832068/7013

[commit-bot: I haz the power, 2012-07-30 21:58:58]

Failed to apply patch for remoting/host/win/desktop.cc:
While running patch -p0 --forward --force;
A         remoting/host/win
patching file remoting/host/win/desktop.cc
Hunk #1 FAILED at 2.
Hunk #2 FAILED at 10.
Hunk #3 FAILED at 22.
Hunk #4 FAILED at 43.
Hunk #5 FAILED at 55.
Hunk #6 FAILED at 65.
Hunk #7 FAILED at 74.
7 out of 7 hunks FAILED -- saving rejects to file
remoting/host/win/desktop.cc.rej