Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: ui/views/focus/focus_manager.cc

Issue 10832011: Makes NativeViewHostWin change the parent of the hwnd when (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix focus issues Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ui/views/controls/native/native_view_host_win.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/focus/focus_manager.h" 5 #include "ui/views/focus/focus_manager.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/auto_reset.h" 9 #include "base/auto_reset.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 460 matching lines...) Expand 10 before | Expand all | Expand 10 after
471 // static 471 // static
472 bool FocusManager::IsTabTraversalKeyEvent(const KeyEvent& key_event) { 472 bool FocusManager::IsTabTraversalKeyEvent(const KeyEvent& key_event) {
473 return key_event.key_code() == ui::VKEY_TAB && !key_event.IsControlDown(); 473 return key_event.key_code() == ui::VKEY_TAB && !key_event.IsControlDown();
474 } 474 }
475 475
476 void FocusManager::ViewRemoved(View* removed) { 476 void FocusManager::ViewRemoved(View* removed) {
477 // If the view being removed contains (or is) the focused view, 477 // If the view being removed contains (or is) the focused view,
478 // clear the focus. However, it's not safe to call ClearFocus() 478 // clear the focus. However, it's not safe to call ClearFocus()
479 // (and in turn ClearNativeFocus()) here because ViewRemoved() can 479 // (and in turn ClearNativeFocus()) here because ViewRemoved() can
480 // be called while the top level widget is being destroyed. 480 // be called while the top level widget is being destroyed.
481 if (focused_view_ && removed && removed->Contains(focused_view_)) 481 if (focused_view_ && removed->Contains(focused_view_))
482 SetFocusedView(NULL); 482 SetFocusedView(NULL);
483 } 483 }
484 484
485 void FocusManager::AddFocusChangeListener(FocusChangeListener* listener) { 485 void FocusManager::AddFocusChangeListener(FocusChangeListener* listener) {
486 focus_change_listeners_.AddObserver(listener); 486 focus_change_listeners_.AddObserver(listener);
487 } 487 }
488 488
489 void FocusManager::RemoveFocusChangeListener(FocusChangeListener* listener) { 489 void FocusManager::RemoveFocusChangeListener(FocusChangeListener* listener) {
490 focus_change_listeners_.RemoveObserver(listener); 490 focus_change_listeners_.RemoveObserver(listener);
491 } 491 }
492 492
493 } // namespace views 493 } // namespace views
OLDNEW
« no previous file with comments | « ui/views/controls/native/native_view_host_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698