Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10831407: Kill PropertyBag, switch WebContents to SupportsUserData. (Closed)

Created:
8 years, 4 months ago by Avi (use Gerrit)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Avi (use Gerrit), James Su, creis+watch_chromium.org, tfarina, brettw-cc_chromium.org, jam, dcheng, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, erikwright+watch_chromium.org
Visibility:
Public.

Description

Kill PropertyBag, switch WebContents to SupportsUserData. BUG=141177 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152882

Patch Set 1 #

Patch Set 2 : works #

Total comments: 2

Patch Set 3 : ben's nits #

Patch Set 4 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -511 lines) Patch
M base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
D base/property_bag.h View 1 chunk +0 lines, -179 lines 0 comments Download
D base/property_bag.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D base/property_bag_unittest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 4 chunks +10 lines, -16 lines 0 comments Download
M chrome/browser/ui/cocoa/web_dialog_window_controller.mm View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc View 4 chunks +9 lines, -15 lines 0 comments Download
M chrome/browser/ui/gtk/web_dialog_gtk.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.cc View 4 chunks +21 lines, -15 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 4 chunks +23 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 4 chunks +9 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.cc View 1 5 chunks +9 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 4 chunks +27 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/view_type_utils.cc View 1 chunk +21 lines, -11 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 3 chunks +0 lines, -7 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M content/public/browser/web_contents.h View 4 chunks +4 lines, -8 lines 0 comments Download
M ui/views/controls/webview/web_dialog_view.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ui/web_dialogs/constrained_web_dialog_ui.h View 2 chunks +6 lines, -10 lines 0 comments Download
M ui/web_dialogs/constrained_web_dialog_ui.cc View 1 2 3 chunks +35 lines, -13 lines 0 comments Download
M ui/web_dialogs/web_dialog_ui.h View 3 chunks +13 lines, -14 lines 0 comments Download
M ui/web_dialogs/web_dialog_ui.cc View 5 chunks +39 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
Brett for base/, Ben for everything else.
8 years, 4 months ago (2012-08-21 18:01:35 UTC) #1
Ben Goodger (Google)
lgtm https://chromiumcodereview.appspot.com/10831407/diff/5003/ui/web_dialogs/constrained_web_dialog_ui.cc File ui/web_dialogs/constrained_web_dialog_ui.cc (right): https://chromiumcodereview.appspot.com/10831407/diff/5003/ui/web_dialogs/constrained_web_dialog_ui.cc#newcode38 ui/web_dialogs/constrained_web_dialog_ui.cc:38: ConstrainedWebDialogDelegate* delegate() { return delegate_; } nit: nl ...
8 years, 4 months ago (2012-08-22 19:43:28 UTC) #2
Avi (use Gerrit)
OK, done.
8 years, 4 months ago (2012-08-22 20:06:45 UTC) #3
brettw
base lgtm
8 years, 4 months ago (2012-08-22 21:25:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10831407/12001
8 years, 4 months ago (2012-08-22 21:26:33 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-23 00:03:17 UTC) #6 
Change committed as 152882

Powered by Google App Engine
This is Rietveld 408576698