Kill PropertyBag, switch WebContents to SupportsUserData.

ui/web_dialogs/constrained_web_dialog_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/web_dialogs/constrained_web_dialog_ui.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/lazy_instance.h"
-#include "base/property_bag.h"
 #include "base/values.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui.h"
 #include "ui/web_dialogs/web_dialog_delegate.h"
 #include "ui/web_dialogs/web_dialog_ui.h"
 
 using content::RenderViewHost;
 using content::WebContents;
 using content::WebUIMessageHandler;
 
-static base::LazyInstance<
-    base::PropertyAccessor<ui::ConstrainedWebDialogDelegate*> >
-    g_constrained_web_dialog_ui_property_accessor = LAZY_INSTANCE_INITIALIZER;
+namespace ui {
 
-namespace ui {
+namespace {
+
+const char kConstrainedWebDialogDelegateUserDataKey[] =
+    "ConstrainedWebDialogDelegateUserData";
+
+class ConstrainedWebDialogDelegateUserData
+    : public base::SupportsUserData::Data {
+ public:
+  explicit ConstrainedWebDialogDelegateUserData(
+      ConstrainedWebDialogDelegate* delegate) : delegate_(delegate) {}
+  virtual ~ConstrainedWebDialogDelegateUserData() {}
+  ConstrainedWebDialogDelegate* delegate() { return delegate_; }

[Ben Goodger (Google), 2012/08/22 19:43:29]

nit: nl above

+
+ private:
+  ConstrainedWebDialogDelegate* delegate_;  // unowned
+};

[Ben Goodger (Google), 2012/08/22 19:43:29]

DISALLOW_COPY_AND..

+
+}  // namespace
 
 ConstrainedWebDialogUI::ConstrainedWebDialogUI(content::WebUI* web_ui)
     : WebUIController(web_ui) {
 }
 
 ConstrainedWebDialogUI::~ConstrainedWebDialogUI() {
 }
 
 void ConstrainedWebDialogUI::RenderViewCreated(
     RenderViewHost* render_view_host) {
@@ skipping 24 matching lines @@
   if (!delegate)
     return;
 
   std::string json_retval;
   if (!args->empty() && !args->GetString(0, &json_retval))
     NOTREACHED() << "Could not read JSON argument";
   delegate->GetWebDialogDelegate()->OnDialogClosed(json_retval);
   delegate->OnDialogCloseFromWebUI();
 }
 
-ConstrainedWebDialogDelegate* ConstrainedWebDialogUI::GetConstrainedDelegate() {
-  ConstrainedWebDialogDelegate** property = GetPropertyAccessor().GetProperty(
-      web_ui()->GetWebContents()->GetPropertyBag());
-  return property ? *property : NULL;
+// static
+void ConstrainedWebDialogUI::SetConstrainedDelegate(
+    content::WebContents* web_contents,
+    ConstrainedWebDialogDelegate* delegate) {
+  web_contents->SetUserData(&kConstrainedWebDialogDelegateUserDataKey,
+                            new ConstrainedWebDialogDelegateUserData(delegate));
 }
 
-// static
-base::PropertyAccessor<ConstrainedWebDialogDelegate*>&
-    ConstrainedWebDialogUI::GetPropertyAccessor() {
-  return g_constrained_web_dialog_ui_property_accessor.Get();
+ConstrainedWebDialogDelegate* ConstrainedWebDialogUI::GetConstrainedDelegate() {
+  ConstrainedWebDialogDelegateUserData* user_data =
+      static_cast<ConstrainedWebDialogDelegateUserData*>(
+          web_ui()->GetWebContents()->
+              GetUserData(&kConstrainedWebDialogDelegateUserDataKey));
+
+  return user_data ? user_data->delegate() : NULL;
 }
 
 }  // namespace ui