Change HistoryAndBookmarkRow favicon_ field to be scoped_refptr<base::RefCountedMemory>

chrome/browser/history/android/android_provider_backend.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/android/android_provider_backend.h"
 
 #include "base/i18n/case_conversion.h"
 #include "chrome/browser/bookmarks/bookmark_service.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/browser/history/android/android_time.h"
@@ skipping 367 matching lines @@
   if (!history_db_->GetURLRow(row.url_id(), &url_row))
     return false;
 
   scoped_ptr<URLsModifiedDetails> modified(new URLsModifiedDetails);
   if (!modified.get())
     return false;
   modified->changed_urls.push_back(url_row);
 
   scoped_ptr<FaviconChangeDetails> favicon;
   if (row.is_value_set_explicitly(HistoryAndBookmarkRow::FAVICON) &&
-      !row.favicon().empty()) {
+      row.favicon_valid()) {
     favicon.reset(new FaviconChangeDetails);
     if (!favicon.get())
       return false;
     favicon->urls.insert(url_row.url());
   }
 
   notifications->push_back(HistoryNotification(
       chrome::NOTIFICATION_HISTORY_URLS_MODIFIED, modified.release()));
   if (favicon.get())
     notifications->push_back(HistoryNotification(
@@ skipping 560 matching lines @@
   scoped_ptr<URLsDeletedDetails> deleted_details(new URLsDeletedDetails);
   scoped_ptr<FaviconChangeDetails> favicon_details(new FaviconChangeDetails);
   scoped_ptr<URLsModifiedDetails> modified(new URLsModifiedDetails);
   URLRow old_url_row;
   if (!history_db_->GetURLRow(ids[0].url_id, &old_url_row))
     return false;
   deleted_details->rows.push_back(old_url_row);
 
   FaviconID favicon_id = statement->statement()->ColumnInt64(4);
   if (favicon_id) {
-    std::vector<unsigned char> favicon;
-    if (!thumbnail_db_->GetFavicon(favicon_id, NULL, &favicon, NULL, NULL))
+    scoped_refptr<base::RefCountedBytes> favicon = new base::RefCountedBytes();
+    if (!thumbnail_db_->GetFavicon(favicon_id, NULL, &favicon->data(), NULL,
+                                   NULL))
       return false;
-    if (!favicon.empty())
+    if (favicon->size())
       new_row.set_favicon(favicon);
     favicon_details->urls.insert(old_url_row.url());
     favicon_details->urls.insert(row.url());
   }
   new_row.set_is_bookmark(statement->statement()->ColumnBool(5));
 
   // The SQLHandler vector is not used here because the row in android_url
   // shouldn't be deleted, we need keep the AndroidUIID unchanged, so it
   // appears update to the client.
   if (!urls_handler_->Delete(ids))
@@ skipping 181 matching lines @@
       return false;
 
     if (!history_db_->SetKeywordSearchTermsForURL(bookmark_row.url_id(),
                           values.template_url_id(), values.search_term()))
       return false;
   }
   return true;
 }
 
 }  // namespace history