Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 10831323: Update parser to not check that all final fields are initialized for external constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/parser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl_test.cc
diff --git a/runtime/vm/dart_api_impl_test.cc b/runtime/vm/dart_api_impl_test.cc
index 0f613b503412a40a807c9691f00427a0b4b73ae2..e7fb2bd50d583d17a1d67d6983d309a534dd7f9f 100644
--- a/runtime/vm/dart_api_impl_test.cc
+++ b/runtime/vm/dart_api_impl_test.cc
@@ -5479,7 +5479,9 @@ TEST_CASE(ParsePatchLibrary) {
const char* kLibraryChars =
"#library('patched_library');\n"
"class A {\n"
+ " final int _final;\n"
" var _f;\n"
+ " external A();"
" external method(var value);\n"
" get field() => _field;\n"
"}\n"
@@ -5491,6 +5493,7 @@ TEST_CASE(ParsePatchLibrary) {
const char* kPatchChars =
"patch class A {\n"
" var _g;\n"
+ " A() : _final = 42;"
" get _field() => _g;\n"
" patch method(var value) {\n"
" _g = value * 5;\n"
« no previous file with comments | « no previous file | runtime/vm/parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698