Issue 10831323: Update parser to not check that all final fields are initialized for external constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831323: Update parser to not check that all final fields are initialized for external constructors. (Closed)

Created:
8 years, 4 months ago by Mads Ager (google)

Modified:
8 years, 4 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update parser to not check that all final fields are initialized for external constructors. Instead treat initializer lists on external constructors as a parse error. I would like to have a regression test for this. However, this seems to only be an issue when running with --compile_all so the test that I put in does not actually trigger the issue. However, we do see the issue when running tests with --compile_all when using the patch support for the date library. R=iposva@google.com BUG=

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -1 line)			Patch
M	runtime/vm/dart_api_impl_test.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	2 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

8 years, 4 months ago (2012-08-15 09:43:12 UTC) #1

Request for comments. When testing with --compile_all with a class that has
final fields and an external constructor we get errors that not all final fields
are initialized. This fixes it, but is it the right way to fix it?

Expand Messages | Collapse Messages