Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 10831316: Eliminate the 'build_ppapi_ipc_proxy_untrusted' build flag for untrusted PPAPI proxy builds. (Closed)

Created:
8 years, 4 months ago by bbudge
Modified:
8 years, 4 months ago
Reviewers:
brettw, bruening
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Eliminate the 'build_ppapi_ipc_proxy_untrusted' build flag for untrusted PPAPI proxy builds. This CL removes our custom GYP flag and modifies the build so both the SRPC and IPC proxies are built side by side. In addition, NaClBrowser now checks the '--enable-nacl-ipc-proxy' flag to determine which IRT to load. The IPC proxy's name is of the form 'nacl_ipc_irt_*'. BUG=116317 TEST=builds and runs NaCl apps with --enable-nacl-ipc-proxy TBR=bbudge@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151693

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -92 lines) Patch
M build/all.gyp View 2 chunks +0 lines, -14 lines 0 comments Download
M build/common.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/nacl_host/nacl_browser.cc View 4 chunks +17 lines, -8 lines 0 comments Download
M chrome/nacl.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/native_client/native_client.gyp View 3 chunks +6 lines, -16 lines 0 comments Download
A + ppapi/ppapi_ipc_proxy_untrusted.gyp View 0 chunks +-1 lines, --1 lines 0 comments Download
M ppapi/ppapi_proxy_untrusted.gyp View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bbudge
Trying to re-land this. It depends on: http://codereview.chromium.org/10823328/ This fixes the NaCl IPC IRT build ...
8 years, 4 months ago (2012-08-14 23:45:12 UTC) #1
bbudge
On 2012/08/14 23:45:12, bbudge1 wrote: > Trying to re-land this. It depends on: > > ...
8 years, 4 months ago (2012-08-14 23:47:05 UTC) #2
bbudge
On 2012/08/14 23:47:05, bbudge1 wrote: > On 2012/08/14 23:45:12, bbudge1 wrote: > > Trying to ...
8 years, 4 months ago (2012-08-14 23:50:26 UTC) #3
Brad Chen
8 years, 4 months ago (2012-08-17 16:49:17 UTC) #4
It looks as though this change has induced compile failures on the heapcheck bot
(Memory FYI waterfall). See
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Heapcheck/bu...
Derek and I are trying to figure out how to fix this; clues would be
appreciated.

On 2012/08/14 23:50:26, bbudge1 wrote:
> On 2012/08/14 23:47:05, bbudge1 wrote:
> > On 2012/08/14 23:45:12, bbudge1 wrote:
> > > Trying to re-land this. It depends on:
> > > 
> > > http://codereview.chromium.org/10823328/
> > > 
> > > This fixes the NaCl IPC IRT build when USE_AURA is true.
> > 
> > This patch is identical to the previous one.
> 
> I need to wait for bots to catch up before running tries.

Powered by Google App Engine
This is Rietveld 408576698