Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: ppapi/native_client/native_client.gyp

Issue 10831316: Eliminate the 'build_ppapi_ipc_proxy_untrusted' build flag for untrusted PPAPI proxy builds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/nacl.gypi ('k') | ppapi/ppapi_ipc_proxy_untrusted.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/native_client.gyp
===================================================================
--- ppapi/native_client/native_client.gyp (revision 151607)
+++ ppapi/native_client/native_client.gyp (working copy)
@@ -53,12 +53,6 @@
},
],
},
- ],
- }],
- # TODO(bbudge) Remove the build_ppapi_ipc_proxy_untrusted flag, factor out common
- # properties from both IRT flavors, and build them side by side.
- ['disable_nacl==0 and disable_nacl_untrusted==0 and build_ppapi_ipc_proxy_untrusted==0', {
- 'targets': [
{
'target_name': 'nacl_irt',
'type': 'none',
@@ -183,20 +177,16 @@
'../../native_client/src/shared/gio/gio.gyp:gio_lib',
],
},
- ],
- }],
- ['disable_nacl==0 and disable_nacl_untrusted==0 and build_ppapi_ipc_proxy_untrusted==1', {
- 'targets': [
{
- 'target_name': 'nacl_irt',
+ 'target_name': 'nacl_ipc_irt',
'type': 'none',
'variables': {
- 'nexe_target': 'nacl_irt',
+ 'nexe_target': 'nacl_ipc_irt',
# These out_* fields override the default filenames, which
# include a "_newlib" suffix.
- 'out_newlib64': '<(PRODUCT_DIR)/nacl_irt_x86_64.nexe',
- 'out_newlib32': '<(PRODUCT_DIR)/nacl_irt_x86_32.nexe',
- 'out_newlib_arm': '<(PRODUCT_DIR)/nacl_irt_arm.nexe',
+ 'out_newlib64': '<(PRODUCT_DIR)/nacl_ipc_irt_x86_64.nexe',
+ 'out_newlib32': '<(PRODUCT_DIR)/nacl_ipc_irt_x86_32.nexe',
+ 'out_newlib_arm': '<(PRODUCT_DIR)/nacl_ipc_irt_arm.nexe',
'build_glibc': 0,
'build_newlib': 1,
'include_dirs': [
@@ -375,7 +365,7 @@
],
},
'dependencies': [
- '../ppapi_proxy_untrusted.gyp:ppapi_proxy_untrusted',
+ '../ppapi_ipc_proxy_untrusted.gyp:ppapi_proxy_untrusted',
'../ppapi_shared_untrusted.gyp:ppapi_shared_untrusted',
'../../gpu/command_buffer/command_buffer_untrusted.gyp:gles2_utils_untrusted',
'../../gpu/gpu_untrusted.gyp:command_buffer_client_untrusted',
« no previous file with comments | « chrome/nacl.gypi ('k') | ppapi/ppapi_ipc_proxy_untrusted.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698