Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 10831270: Eliminate build differences in nacl gated on nacl_standalone.

Created:
8 years, 4 months ago by bradn
Modified:
8 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Eliminate build differences in nacl gated on nacl_standalone. We currently use nacl_standalone to gate two things: - differing settings in the gyp build - toggle the plugin Keeping our settings in sync with chrome is a pseudo-circularity. Additionally, we will temporarily want to use nacl's gyp build to build a full IRT. This is not possible without using chrome's build settings which are expected by ppapi modules to be injected via -Icommon.gypi. R=ncbray@chromium.org BUG=http://code.google.com/p/nativeclient/issues/detail?id=2957 TEST=None

Patch Set 1 #

Patch Set 2 : wrong url #

Patch Set 3 : fix #

Patch Set 4 : git try #

Patch Set 5 : fix clang #

Patch Set 6 : win #

Patch Set 7 : fix threads #

Patch Set 8 : drop chdir #

Patch Set 9 : cull more #

Patch Set 10 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -893 lines) Patch
M DEPS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/common.gypi View 1 2 3 4 5 6 7 8 9 4 chunks +17 lines, -666 lines 0 comments Download
D build/configs.gypi View 1 chunk +0 lines, -154 lines 0 comments Download
D build/external_code.gypi View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -41 lines 0 comments Download
M build/gyp_nacl View 1 2 3 4 5 6 7 2 chunks +19 lines, -12 lines 0 comments Download
M buildbot/buildbot_lib.py View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M buildbot/buildbot_selector.py View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M src/trusted/nonnacl_util/nonnacl_util.gyp View 1 2 3 2 chunks +8 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
bradn
8 years, 4 months ago (2012-08-10 18:39:27 UTC) #1
bradn
8 years, 4 months ago (2012-08-12 21:46:23 UTC) #2
Ok, I think this is ready for review.
There's a small question around clang, but I'll chat with you in person for
that.

Powered by Google App Engine
This is Rietveld 408576698