Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 10831240: Remove TouchEvent interface, and rename TouchEventImpl to TouchEvent (Closed)

Created:
8 years, 4 months ago by sadrul
Modified:
8 years, 4 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Remove TouchEvent interface, and rename TouchEventImpl to TouchEvent. BUG=125937 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150918

Patch Set 1 : . #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : merge-tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+548 lines, -746 lines) Patch
M ash/accelerators/accelerator_filter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_filter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/display/mouse_cursor_event_filter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/display/mouse_cursor_event_filter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_tooltip_manager.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_tooltip_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_tooltip_manager_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/magnification_controller.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_bubble_view.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_bubble_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/tooltips/tooltip_controller.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/tooltips/tooltip_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_observer_hud.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_observer_hud.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_uma.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_uma.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/app_list_controller.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/app_list_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/event_rewriter_event_filter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/event_rewriter_event_filter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overlay_event_filter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overlay_event_filter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panel_window_event_filter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panel_window_event_filter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/shelf_layout_manager.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/system_gesture_event_filter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M ash/wm/system_modal_container_event_filter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_modal_container_event_filter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_filter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_filter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/user_activity_detector.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/user_activity_detector.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/user_activity_detector_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_cycle_controller.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/window_manager_unittest.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/window_modality_controller.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_modality_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_modality_controller_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/frame_maximize_button.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 2 3 4 18 chunks +61 lines, -114 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aurax11.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_seccomp_bpf_linux.cc View 1 2 3 4 16 chunks +117 lines, -111 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/event_filter.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/event_filter_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 2 100 chunks +125 lines, -125 lines 0 comments Download
M ui/aura/root_window.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ui/aura/root_window.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M ui/aura/root_window_host_delegate.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/root_window_host_linux.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/root_window_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/shared/compound_event_filter.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ui/aura/shared/compound_event_filter.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/shared/compound_event_filter_unittest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M ui/aura/shared/input_method_event_filter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/shared/input_method_event_filter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/event_generator.cc View 1 2 9 chunks +13 lines, -13 lines 0 comments Download
M ui/aura/test/test_event_filter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_event_filter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_window_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_window_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_delegate.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 2 13 chunks +15 lines, -15 lines 0 comments Download
M ui/base/event.h View 1 2 3 4 4 chunks +32 lines, -21 lines 0 comments Download
M ui/base/event.cc View 1 2 4 chunks +4 lines, -40 lines 0 comments Download
M ui/base/gestures/gesture_point.cc View 1 2 6 chunks +21 lines, -20 lines 0 comments Download
M ui/base/gestures/gesture_recognizer_impl.cc View 1 2 5 chunks +16 lines, -65 lines 0 comments Download
M ui/base/gestures/gesture_sequence.cc View 1 2 10 chunks +23 lines, -22 lines 0 comments Download
M ui/base/gestures/gesture_types.h View 1 2 3 chunks +5 lines, -20 lines 0 comments Download
M ui/views/events/event.h View 1 2 3 4 4 chunks +2 lines, -18 lines 0 comments Download
M ui/views/events/event.cc View 1 2 3 4 2 chunks +0 lines, -43 lines 0 comments Download
M ui/views/events/event_aura.cc View 1 2 3 4 2 chunks +5 lines, -10 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M ui/views/widget/x11_window_event_filter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/x11_window_event_filter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
sadrul
8 years, 4 months ago (2012-08-09 22:01:05 UTC) #1
sadrul
There are some changes in ui/base/gestures/ to get rid of the dependency on ui::TouchEvent interface, ...
8 years, 4 months ago (2012-08-09 22:06:02 UTC) #2
Ben Goodger (Google)
8 years, 4 months ago (2012-08-09 22:20:33 UTC) #3
cool. lgtm. land quickly!

Powered by Google App Engine
This is Rietveld 408576698