Move BuildCallGetter/BuildCallSetter up in the call chain.

Move BuildCallGetter/BuildCallSetter up in the call chain.

This is a refactoring-only CL and the third one in a series for enabling
inlining of accessors. The goal of this CL is to move the builders for accessors
to the places where we might be able to inline them later, i.e. the VisitFoo and
HandleBar member functions of HGraphBuilder.

Extracted duplicate code into LookupAccessorPair.

Committed: https://code.google.com/p/v8/source/detail?r=12209

[Michael Starzinger, 2012-07-27 09:19:23]

LGTM (with nits).

https://chromiumcodereview.appspot.com/10831047/diff/1/src/hydrogen.h
File src/hydrogen.h (right):

https://chromiumcodereview.appspot.com/10831047/diff/1/src/hydrogen.h#newcode...
src/hydrogen.h:1091: HLoadNamedField* BuildLoadNamedField(HValue* object,
I know it's not part of your change, but can we move the declaration of this
method into the block of property-related BuildFoo() methods?

https://chromiumcodereview.appspot.com/10831047/diff/1/src/hydrogen.h#newcode...
src/hydrogen.h:1095: HInstruction* BuildLoadNamedGeneric(HValue* object,
Likewise.

https://chromiumcodereview.appspot.com/10831047/diff/1/src/hydrogen.h#newcode...
src/hydrogen.h:1098: HInstruction* BuildLoadKeyedGeneric(HValue* object, HValue*
key);
Likewise.

https://chromiumcodereview.appspot.com/10831047/diff/1/src/hydrogen.h#newcode...
src/hydrogen.h:1154: bool LookupAccessorPair(Handle<Map> map,
Can we have a short comment what this method does and about the semantics of the
return value. Also I would move it up a few lines in front of the block of
property-related BuildFoo() methods.

[Sven Panne, 2012-07-27 09:42:40]

Landing...

http://codereview.chromium.org/10831047/diff/1/src/hydrogen.h
File src/hydrogen.h (right):

http://codereview.chromium.org/10831047/diff/1/src/hydrogen.h#newcode1091
src/hydrogen.h:1091: HLoadNamedField* BuildLoadNamedField(HValue* object,
On 2012/07/27 09:19:23, Michael Starzinger wrote:
> I know it's not part of your change, but can we move the declaration of this
> method into the block of property-related BuildFoo() methods?

Done.

http://codereview.chromium.org/10831047/diff/1/src/hydrogen.h#newcode1095
src/hydrogen.h:1095: HInstruction* BuildLoadNamedGeneric(HValue* object,
On 2012/07/27 09:19:23, Michael Starzinger wrote:
> Likewise.

Done.

http://codereview.chromium.org/10831047/diff/1/src/hydrogen.h#newcode1098
src/hydrogen.h:1098: HInstruction* BuildLoadKeyedGeneric(HValue* object, HValue*
key);
On 2012/07/27 09:19:23, Michael Starzinger wrote:
> Likewise.

Done.

http://codereview.chromium.org/10831047/diff/1/src/hydrogen.h#newcode1154
src/hydrogen.h:1154: bool LookupAccessorPair(Handle<Map> map,
On 2012/07/27 09:19:23, Michael Starzinger wrote:
> Can we have a short comment what this method does and about the semantics of
the
> return value. Also I would move it up a few lines in front of the block of
> property-related BuildFoo() methods.

Done.