Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: src/hydrogen.h

Issue 10831047: Move BuildCallGetter/BuildCallSetter up in the call chain. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Incorporated review comments. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1070 matching lines...) Expand 10 before | Expand all | Expand 10 after
1081 NilValue nil); 1081 NilValue nil);
1082 1082
1083 HStringCharCodeAt* BuildStringCharCodeAt(HValue* context, 1083 HStringCharCodeAt* BuildStringCharCodeAt(HValue* context,
1084 HValue* string, 1084 HValue* string,
1085 HValue* index); 1085 HValue* index);
1086 HInstruction* BuildBinaryOperation(BinaryOperation* expr, 1086 HInstruction* BuildBinaryOperation(BinaryOperation* expr,
1087 HValue* left, 1087 HValue* left,
1088 HValue* right); 1088 HValue* right);
1089 HInstruction* BuildIncrement(bool returns_original_input, 1089 HInstruction* BuildIncrement(bool returns_original_input,
1090 CountOperation* expr); 1090 CountOperation* expr);
1091 HLoadNamedField* BuildLoadNamedField(HValue* object,
1092 Handle<Map> map,
1093 LookupResult* result,
1094 bool smi_and_map_check);
1095 HInstruction* BuildLoadNamedGeneric(HValue* object,
1096 Handle<String> name,
1097 Property* expr);
1098 HInstruction* BuildLoadKeyedGeneric(HValue* object, HValue* key);
1099 HInstruction* BuildExternalArrayElementAccess(
1100 HValue* external_elements,
1101 HValue* checked_key,
1102 HValue* val,
1103 HValue* dependency,
1104 ElementsKind elements_kind,
1105 bool is_store);
1106 HInstruction* BuildFastElementAccess(HValue* elements, 1091 HInstruction* BuildFastElementAccess(HValue* elements,
1107 HValue* checked_key, 1092 HValue* checked_key,
1108 HValue* val, 1093 HValue* val,
1109 HValue* dependency, 1094 HValue* dependency,
1110 ElementsKind elements_kind, 1095 ElementsKind elements_kind,
1111 bool is_store); 1096 bool is_store);
1112 1097
1113 HInstruction* TryBuildConsolidatedElementLoad(HValue* object, 1098 HInstruction* TryBuildConsolidatedElementLoad(HValue* object,
1114 HValue* key, 1099 HValue* key,
1115 HValue* val, 1100 HValue* val,
(...skipping 24 matching lines...) Expand all
1140 1125
1141 HValue* HandleKeyedElementAccess(HValue* obj, 1126 HValue* HandleKeyedElementAccess(HValue* obj,
1142 HValue* key, 1127 HValue* key,
1143 HValue* val, 1128 HValue* val,
1144 Expression* expr, 1129 Expression* expr,
1145 int ast_id, 1130 int ast_id,
1146 int position, 1131 int position,
1147 bool is_store, 1132 bool is_store,
1148 bool* has_side_effects); 1133 bool* has_side_effects);
1149 1134
1135 // Tries to find a JavaScript accessor of the given name in the prototype
1136 // chain starting at the given map. Return true iff there is one, including
1137 // the corresponding AccessorPair plus its holder (which could be null when
1138 // the accessor is found directly in the given map).
1139 bool LookupAccessorPair(Handle<Map> map,
1140 Handle<String> name,
1141 Handle<AccessorPair>* accessors,
1142 Handle<JSObject>* holder);
1143
1144 HLoadNamedField* BuildLoadNamedField(HValue* object,
1145 Handle<Map> map,
1146 LookupResult* result,
1147 bool smi_and_map_check);
1148 HInstruction* BuildLoadNamedGeneric(HValue* object,
1149 Handle<String> name,
1150 Property* expr);
1150 HInstruction* BuildCallGetter(HValue* object, 1151 HInstruction* BuildCallGetter(HValue* object,
1151 Handle<Map> map, 1152 Handle<Map> map,
1152 Handle<AccessorPair> accessors, 1153 Handle<AccessorPair> accessors,
1153 Handle<JSObject> holder); 1154 Handle<JSObject> holder);
1154 HInstruction* BuildLoadNamedMonomorphic(HValue* object, 1155 HInstruction* BuildLoadNamedMonomorphic(HValue* object,
1155 Handle<String> name, 1156 Handle<String> name,
1156 Property* expr, 1157 Property* expr,
1157 Handle<Map> map); 1158 Handle<Map> map);
1158 HInstruction* BuildCallSetter(HValue* object, 1159 HInstruction* BuildLoadKeyedGeneric(HValue* object, HValue* key);
1159 HValue* value, 1160 HInstruction* BuildExternalArrayElementAccess(
1160 Handle<Map> map, 1161 HValue* external_elements,
1161 Handle<AccessorPair> accessors, 1162 HValue* checked_key,
1162 Handle<JSObject> holder); 1163 HValue* val,
1163 HInstruction* BuildStoreNamedMonomorphic(HValue* object, 1164 HValue* dependency,
1164 Handle<String> name, 1165 ElementsKind elements_kind,
1165 HValue* value, 1166 bool is_store);
1166 Handle<Map> map); 1167
1167 HInstruction* BuildStoreNamedField(HValue* object, 1168 HInstruction* BuildStoreNamedField(HValue* object,
1168 Handle<String> name, 1169 Handle<String> name,
1169 HValue* value, 1170 HValue* value,
1170 Handle<Map> map, 1171 Handle<Map> map,
1171 LookupResult* lookup, 1172 LookupResult* lookup,
1172 bool smi_and_map_check); 1173 bool smi_and_map_check);
1173 HInstruction* BuildStoreNamedGeneric(HValue* object, 1174 HInstruction* BuildStoreNamedGeneric(HValue* object,
1174 Handle<String> name, 1175 Handle<String> name,
1175 HValue* value); 1176 HValue* value);
1177 HInstruction* BuildCallSetter(HValue* object,
1178 HValue* value,
1179 Handle<Map> map,
1180 Handle<AccessorPair> accessors,
1181 Handle<JSObject> holder);
1182 HInstruction* BuildStoreNamedMonomorphic(HValue* object,
1183 Handle<String> name,
1184 HValue* value,
1185 Handle<Map> map);
1176 HInstruction* BuildStoreKeyedGeneric(HValue* object, 1186 HInstruction* BuildStoreKeyedGeneric(HValue* object,
1177 HValue* key, 1187 HValue* key,
1178 HValue* value); 1188 HValue* value);
1179 1189
1180 HValue* BuildContextChainWalk(Variable* var); 1190 HValue* BuildContextChainWalk(Variable* var);
1181 1191
1182 HInstruction* BuildThisFunction(); 1192 HInstruction* BuildThisFunction();
1183 1193
1184 void AddCheckConstantFunction(Handle<JSObject> holder, 1194 void AddCheckConstantFunction(Handle<JSObject> holder,
1185 HValue* receiver, 1195 HValue* receiver,
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
1456 const char* filename_; 1466 const char* filename_;
1457 HeapStringAllocator string_allocator_; 1467 HeapStringAllocator string_allocator_;
1458 StringStream trace_; 1468 StringStream trace_;
1459 int indent_; 1469 int indent_;
1460 }; 1470 };
1461 1471
1462 1472
1463 } } // namespace v8::internal 1473 } } // namespace v8::internal
1464 1474
1465 #endif // V8_HYDROGEN_H_ 1475 #endif // V8_HYDROGEN_H_
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698