Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 10831039: Allow the mac_sdk_path GYP variable to set the Mac OS X SDK by path (Closed)

Created:
8 years, 5 months ago by Mark Mentovai
Modified:
8 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Allow the mac_sdk_path GYP variable to set the Mac OS X SDK by path. This is useful for cases where Xcode doesn't know about the SDK, possibly because the SDK is installed outside of Xcode altogether. For example, Xcode 4.4 does not include a copy of the 10.6 SDK, so if you have a copy of the 10.6 SDK present at /SDKs/MacOSX10.6.sdk, you can put this in ~/.gyp/include.gypi: { 'variables': { 'mac_sdk_path': '/SDKs/MacOSX10.6.sdk', }, } Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148680

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 2 chunks +19 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mark Mentovai
For ninja, this depends on https://chromiumcodereview.appspot.com/10821053 .
8 years, 5 months ago (2012-07-26 21:48:27 UTC) #1
Nico
I think I can get chrome trunk building with the 10.7 SDK. Maybe we should ...
8 years, 5 months ago (2012-07-26 22:34:44 UTC) #2
Mark Mentovai
At some point we’re going to need to give up on Xcode 3.2 but still ...
8 years, 5 months ago (2012-07-26 22:37:35 UTC) #3
Nico
On 2012/07/26 22:37:35, Mark Mentovai wrote: > At some point we’re going to need to ...
8 years, 5 months ago (2012-07-26 22:38:37 UTC) #4
Mark Mentovai
4.3’s dead, and anything pre-4.4 has a potential privacy hole that won’t be patched (although ...
8 years, 5 months ago (2012-07-26 22:43:22 UTC) #5
Nico
LGTM Nothing, just trying to keep this file shorter. This makes sense for bots. For ...
8 years, 5 months ago (2012-07-26 22:48:24 UTC) #6
Mark Mentovai
There are other things we found in remoting that are deprecated in the 10.6 SDK ...
8 years, 5 months ago (2012-07-26 22:52:41 UTC) #7
Nico
On Thu, Jul 26, 2012 at 3:52 PM, <mark@chromium.org> wrote: > There are other things ...
8 years, 5 months ago (2012-07-26 22:56:49 UTC) #8
Mark Mentovai
8 years, 5 months ago (2012-07-26 23:17:34 UTC) #9
Awesome!

Powered by Google App Engine
This is Rietveld 408576698