Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 10821053: ninja/mac: allow path-based specification of SDKROOT (Closed)

Created:
8 years, 5 months ago by Mark Mentovai
Modified:
8 years, 5 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja/mac: allow path-based specification of SDKROOT This matches the Xcode behavior of SDKROOT treatment. For SDKROOT values that don’t begin with macosx, SDKROOT is treated as a path. When a relative path, it is taken as relative to the .xcodeproj's containing directory, although that isn't duplicated here because it's not likely to be of use. When SDKROOT is an absolute path, it points to the root directory of the SDK itself, such as /Developer/SDKs/MacOSX10.6.sdk or /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.7.sdk . Committed: https://code.google.com/p/gyp/source/detail?r=1440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M pylib/gyp/xcode_emulation.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
This enables https://chromiumcodereview.appspot.com/10831039/ to work for ninja. I wanted to write a test for this ...
8 years, 5 months ago (2012-07-26 21:47:42 UTC) #1
Nico
8 years, 5 months ago (2012-07-26 22:37:56 UTC) #2
lgtm

Matching xcode is good, independent of if we do the other CL.

Powered by Google App Engine
This is Rietveld 408576698