Issue 10831016: NULL check before deref, not after

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831016: NULL check before deref, not after (Closed)

Created:
8 years, 5 months ago by Tyler Breisacher (Chromium)

Modified:
8 years, 5 months ago

Reviewers:
Kyle Horimoto, gavinp

CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, mmenke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NULL check before deref, not after CID=104474 BUG= TEST= TBR=tburkard@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148513

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/prerender/prerender_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

gavinp

On 2012/07/25 22:27:36, Kyle Horimoto wrote: > LGTM LGTM. I introduced this bug in http://codereview.chromium.org/10553029/diff/54003/chrome/browser/prerender/prerender_manager.cc

8 years, 5 months ago (2012-07-25 22:29:11 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/10831016/1

8 years, 5 months ago (2012-07-25 22:39:41 UTC) #4

commit-bot: I haz the power

Try job failure for 10831016-1 (retry) on win_rel for step "browser_tests". It's a second try, ...

8 years, 5 months ago (2012-07-26 01:07:51 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/10831016/1

8 years, 5 months ago (2012-07-26 02:59:54 UTC) #6

Change committed as 148513

Expand Messages | Collapse Messages