chrome/browser/prerender/prerender_manager.cc - Issue 10831016: NULL check before deref, not after

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prerender/prerender_manager.cc

Issue 10831016: NULL check before deref, not after (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prerender/prerender_manager.cc

diff --git a/chrome/browser/prerender/prerender_manager.cc b/chrome/browser/prerender/prerender_manager.cc

index b43eec6bd94e869a3cf20555003360251379897b..5e7b4c6b15d98dc8d424d615db8bf932d7f7f5f1 100644

--- a/chrome/browser/prerender/prerender_manager.cc

+++ b/chrome/browser/prerender/prerender_manager.cc

@@ -462,8 +462,8 @@ void PrerenderManager::MoveEntryToPendingDelete(PrerenderContents* entry,

PrerenderContents* dummy_replacement_prerender_contents =

CreatePrerenderContents(entry->prerender_url(), entry->referrer(),

entry->origin(), entry->experiment_id());

- dummy_replacement_prerender_contents->MakeIntoDummyReplacementOf(entry);

DCHECK(dummy_replacement_prerender_contents);

+ dummy_replacement_prerender_contents->MakeIntoDummyReplacementOf(entry);

dummy_replacement_prerender_contents->set_match_complete_status(

PrerenderContents::MATCH_COMPLETE_REPLACEMENT_PENDING);

« no previous file with comments | « no previous file | no next file » | no next file with comments »