Fixed ExtensionApiTest.Bookmarks and enabled it again.

Fixed ExtensionApiTest.Bookmarks and enabled it again.

Also fixed a little nit in the chrome.bookmarks.create() call, which would return the wrong error code when given an invalid URL.

BUG=18979, 89762
TEST=ExtensionApiTest.Bookmarks in the browser_tests is green


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148556

[Joao da Silva, 2012-07-25 20:06:17]

Hi Scott, can you have a look at this?

I was bitten by the invalid URL bug and had a look; turns out that
url.is_empty() is true when url.is_valid() is false, so the right error was
never triggered. Ended up fixing the bookmarks apitest too, and they didn't
flake on 100 runs locally.

[sky, 2012-07-25 21:22:51]

LGTM

[commit-bot: I haz the power, 2012-07-25 21:50:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10831012/6001

[commit-bot: I haz the power, 2012-07-25 23:31:54]

Try job failure for 10831012-6001 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-07-26 09:16:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10831012/6001

[commit-bot: I haz the power, 2012-07-26 10:21:37]

Try job failure for 10831012-6001 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-07-26 10:27:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10831012/6001

[commit-bot: I haz the power, 2012-07-26 15:49:51]

Change committed as 148556