chrome/browser/bookmarks/bookmark_extension_api.cc - Issue 10831012: Fixed ExtensionApiTest.Bookmarks and enabled it again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/bookmark_extension_api.cc

Issue 10831012: Fixed ExtensionApiTest.Bookmarks and enabled it again. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removed bug comment Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/bookmarks/bookmark_extension_api.cc

diff --git a/chrome/browser/bookmarks/bookmark_extension_api.cc b/chrome/browser/bookmarks/bookmark_extension_api.cc

index 3dc1312a728ad3ea24333bb0cb1badbf897e4ff3..d26c98650d0a53df9d7fbc168847df5fe5f0dda1 100644

--- a/chrome/browser/bookmarks/bookmark_extension_api.cc

+++ b/chrome/browser/bookmarks/bookmark_extension_api.cc

@@ -504,7 +504,7 @@ bool CreateBookmarkFunction::RunImpl() {

std::string url_string;

json->GetString(keys::kUrlKey, &url_string); // Optional.

GURL url(url_string);

- if (!url.is_empty() && !url.is_valid()) {

+ if (!url_string.empty() && !url.is_valid()) {

error_ = keys::kInvalidUrlError;

return false;

}

« no previous file with comments | « no previous file | chrome/browser/bookmarks/bookmark_extension_apitest.cc » ('j') | no next file with comments »