Issue 10830334: Fix bug in compare IC. BUG=2291

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830334: Fix bug in compare IC. BUG=2291 (Closed)

Created:
8 years, 4 months ago by Erik Corry

Modified:
8 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google), Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Fix bug in compare IC. BUG=2291 Committed: https://code.google.com/p/v8/source/detail?r=12313

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -3 lines)			Patch
M	src/code-stubs.cc	View	1 2	2 chunks	+10 lines, -2 lines	0 comments	Download
M	src/heap.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
A	test/mjsunit/regress/regress-2291.js	View		1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

8 years, 4 months ago (2012-08-15 14:24:30 UTC) #2

lgtm with comments

https://chromiumcodereview.appspot.com/10830334/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):

https://chromiumcodereview.appspot.com/10830334/diff/1/src/code-stubs.cc#newc...
src/code-stubs.cc:183: Isolate* isolate = known_map_->GetIsolate();
I would add an assertion here and in AddToSpecialCache that verifies that
operator is either === or ==

https://chromiumcodereview.appspot.com/10830334/diff/1/src/code-stubs.cc#newc...
src/code-stubs.cc:195: *code_out = Code::cast(*probe);
I wonder if we can fetch some information from the code object here and assert
that they match expected values? (e.g. operator, map?)

Expand Messages | Collapse Messages