Fix bug in compare IC. BUG=2291

src/code-stubs.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 154 matching lines @@
 void CodeStub::PrintName(StringStream* stream) {
   stream->Add("%s", MajorName(MajorKey(), false));
 }
 
 
 void ICCompareStub::AddToSpecialCache(Handle<Code> new_object) {
   ASSERT(*known_map_ != NULL);
   Isolate* isolate = new_object->GetIsolate();
   Factory* factory = isolate->factory();
   return Map::UpdateCodeCache(known_map_,
-                              factory->compare_ic_symbol(),
+                              strict() ?
+                                  factory->strict_compare_ic_symbol() :
+                                  factory->compare_ic_symbol(),
                               new_object);
 }
 
 
 bool ICCompareStub::FindCodeInSpecialCache(Code** code_out) {
   Isolate* isolate = known_map_->GetIsolate();

[Vyacheslav Egorov (Google), 2012/08/15 14:24:30]

I would add an assertion here and in AddToSpecialCache that verifies that
operator is either === or ==

   Factory* factory = isolate->factory();
   Code::Flags flags = Code::ComputeFlags(
       static_cast<Code::Kind>(GetCodeKind()),
       UNINITIALIZED);
   Handle<Object> probe(
-      known_map_->FindInCodeCache(*factory->compare_ic_symbol(), flags));
+      known_map_->FindInCodeCache(
+        strict() ?
+            *factory->strict_compare_ic_symbol() :
+            *factory->compare_ic_symbol(),
+        flags));
   if (probe->IsCode()) {
     *code_out = Code::cast(*probe);

[Vyacheslav Egorov (Google), 2012/08/15 14:24:30]

I wonder if we can fetch some information from the code object here and assert
that they match expected values? (e.g. operator, map?)

     return true;
   }
   return false;
 }
 
 
 int ICCompareStub::MinorKey() {
   return OpField::encode(op_ - Token::EQ) | StateField::encode(state_);
 }
 
@@ skipping 286 matching lines @@
   // already active, as the hooks won't stack.
   if (entry_hook != 0 && entry_hook_ != 0)
     return false;
 
   entry_hook_ = entry_hook;
   return true;
 }
 
 
 } }  // namespace v8::internal