Issue 10830211: Revert 150436 - gdata: Remove hide_hosted_documents from ReadDirectoryCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830211: Revert 150436 - gdata: Remove hide_hosted_documents from ReadDirectoryCallback (Closed)

Created:
8 years, 4 months ago by Nikita (slow)

Modified:
8 years, 4 months ago

Reviewers:
satorux1

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 150436 - gdata: Remove hide_hosted_documents from ReadDirectoryCallback Background: We plan to Add ReadDirectoryByPath() to GDataDirectoryService and use the same ReadDirectoryCallback, and hide_hosted_documents turned out to be an obstacle. It's cleaner to check the setting in the caller, where this setting matters anyway. BUG=141147 TEST=confirm that the "show hosted documents" setting works as before Review URL: https://chromiumcodereview.appspot.com/10836137 TBR=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150520

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -24 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_file_system.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View	6 chunks	+24 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_interface.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_proxy.h	View	4 chunks	+2 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc	View	3 chunks	+3 lines, -11 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_system_service.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chromeos/drive_internals_ui.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages