gdata: Remove hide_hosted_documents from ReadDirectoryCallback

gdata: Remove hide_hosted_documents from ReadDirectoryCallback

Background: We plan to Add ReadDirectoryByPath() to GDataDirectoryService
and use the same ReadDirectoryCallback, and hide_hosted_documents  turned
out to be an obstacle. It's cleaner to check the setting in the caller,
where this setting matters anyway.

BUG=141147
TEST=confirm that the "show hosted documents" setting works as before

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150436

[satorux1, 2012-08-07 21:13:48]

please also take a look. this is blocking the other change
http://codereview.chromium.org/10837148/

[achuithb, 2012-08-07 21:21:16]

On 2012/08/07 21:13:48, satorux1 wrote:
> please also take a look. this is blocking the other change
> http://codereview.chromium.org/10837148/

Taking a look

[achuithb, 2012-08-07 21:35:45]

http://codereview.chromium.org/10836137/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10836137/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2979: void
GDataFileSystem::SetHideHostedDocuments(bool hide) {
This function is weird now. hide is unused. The function isn't doing what you'd
expect.

[satorux1, 2012-08-07 21:48:07]

http://codereview.chromium.org/10836137/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10836137/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2979: void
GDataFileSystem::SetHideHostedDocuments(bool hide) {
On 2012/08/07 21:35:45, achuith.bhandarkar wrote:
> This function is weird now. hide is unused. The function isn't doing what
you'd
> expect.

Good point. Removed the function. The only thing we need to do is call the
observers now.

[achuithb, 2012-08-07 21:50:43]

lgtm++ 

good patch!

[kochi, 2012-08-08 07:04:41]

Looks like in OnReadDirectory() in gdata_file_system_proxy.cc,
calling pref_service->GetBoolean() causes
[27872:27884:4945112294398:FATAL:pref_service.cc(548)] Check failed:
CalledOnValidThread()

Shall this be called in UI thread?

[Nikita (slow), 2012-08-08 07:42:19]

I was thinking about reverting this CL but since browser_tests failure is
clearly associated with it, I'll leave it there for now.

[Nikita (slow), 2012-08-08 08:41:07]

Decided to revert though. Otherwise trybots and buildbot are constantly red.

[satorux1, 2012-08-08 12:45:37]

Sorry about that. I wasn't aware of the failure, though it was failing on a try
bot. I forgot that we were dealing with IO thread in the proxy class.

[satorux1, 2012-08-08 14:43:55]

On 2012/08/08 12:45:37, satorux1 wrote:
> Sorry about that. I wasn't aware of the failure, though it was failing on a
try
> bot. I forgot that we were dealing with IO thread in the proxy class.

For the record, I tried to rework this patch, by tweaking
gdata_file_system_proxy.cc to get the setting safely on UI thread. This resulted
in  difficult-to follow code so I gave up on this patch.