Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 10830185: Check for duplicate id strings in ChunkDemuxer::AddId() (Closed)

Created:
8 years, 4 months ago by annacc
Modified:
8 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Check for duplicate id strings in ChunkDemuxer::AddId() WebKit's MediaSource object keeps a private member variable, int m_nextSourceBufferId, for adding source ids since ids are no longer part of the spec. It is possible that this int could wrap around if several source buffers are added. To ensure this doesn't cause problems, ChunkDemuxer::AddId() should check the id string to make sure it is not a duplicate and, if so, throw a ReachedIdLimit error. BUG=140861 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150459

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M media/filters/chunk_demuxer.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
annacc
PTAL!
8 years, 4 months ago (2012-08-06 19:36:32 UTC) #1
acolwell GONE FROM CHROMIUM
LGTM
8 years, 4 months ago (2012-08-06 20:05:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/annacc@chromium.org/10830185/1
8 years, 4 months ago (2012-08-06 20:10:31 UTC) #3
commit-bot: I haz the power
Try job failure for 10830185-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 20:38:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/annacc@chromium.org/10830185/1
8 years, 4 months ago (2012-08-06 22:45:06 UTC) #5
commit-bot: I haz the power
Try job failure for 10830185-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 23:14:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/annacc@chromium.org/10830185/1
8 years, 4 months ago (2012-08-07 04:28:57 UTC) #7
commit-bot: I haz the power
Try job failure for 10830185-1 (retry) on win_rel for step "net_unittests" (clobber build). It's a ...
8 years, 4 months ago (2012-08-07 07:10:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/annacc@chromium.org/10830185/1
8 years, 4 months ago (2012-08-07 22:15:32 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 23:53:37 UTC) #10
Change committed as 150459

Powered by Google App Engine
This is Rietveld 408576698