media/filters/chunk_demuxer.cc - Issue 10830185: Check for duplicate id strings in ChunkDemuxer::AddId()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/chunk_demuxer.cc

Issue 10830185: Check for duplicate id strings in ChunkDemuxer::AddId() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/chunk_demuxer.cc

diff --git a/media/filters/chunk_demuxer.cc b/media/filters/chunk_demuxer.cc

index d503fcca90faa751c217f31e8d3b7d271db53021..5234ae970a73cb4a6a081af2307859f885afc534 100644

--- a/media/filters/chunk_demuxer.cc

+++ b/media/filters/chunk_demuxer.cc

@@ -616,7 +616,8 @@ ChunkDemuxer::Status ChunkDemuxer::AddId(const std::string& id,

DCHECK_GT(codecs.size(), 0u);

base::AutoLock auto_lock(lock_);

- if (state_ != WAITING_FOR_INIT && state_ != INITIALIZING)

+ if ((state_ != WAITING_FOR_INIT && state_ != INITIALIZING) ||

+ stream_parser_map_.count(id) > 0u)

return kReachedIdLimit;

bool has_audio = false;

« no previous file with comments | « no previous file | no next file » | no next file with comments »