Issue 10830158: Refactor GrabWindowSnapshot and GrabWindowSnapshotImpl names to GrabWindowSnapshotForUser and GrabW…

Issue 10830158: Refactor GrabWindowSnapshot and GrabWindowSnapshotImpl names to GrabWindowSnapshotForUser and GrabW… (Closed)

Created:
8 years, 4 months ago by qfel

Modified:
8 years, 4 months ago

Reviewers:
sky, grt (UTC plus 2)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, Sergey Ulanov, Mattias Nissler (ping if slow)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Refactor GrabWindowSnapshot and GrabWindowSnapshotImpl names to GrabWindowSnapshotForUser and GrabWindowSnapshot respectively. Use GrabWindowSnapshot (the old internal version) in tests. BUG=139694 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150085

Patch Set 1 #

Patch Set 2 : Enabled tests #

Total comments: 6

Patch Set 3 : Addressed comments, removed crbug comments #

Patch Set 4 : Fixed compiling tests, fixed indent #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -47 lines)			Patch
M	chrome/browser/ui/ash/screenshot_taker.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/feedback_ui.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/window_snapshot/window_snapshot.h	View	1 2	1 chunk	+19 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/window_snapshot/window_snapshot.cc	View	1 2	1 chunk	+3 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/window_snapshot/window_snapshot_aura.cc	View	1 2	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/window_snapshot/window_snapshot_gtk.cc	View	1 2	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/window_snapshot/window_snapshot_mac.mm	View	1 2	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/window_snapshot/window_snapshot_mac_unittest.mm	View	1 2 3	3 chunks	+2 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/window_snapshot/window_snapshot_win.cc	View	1 2	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/test/base/ui_test_utils_win.cc	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/test/gpu/gpu_pixel_browsertest.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/test/perf/rendering/throughput_tests.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome_frame/test/test_with_web_server.cc	View	1 2	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

qfel

Continuation of https://chromiumcodereview.appspot.com/10821104/

8 years, 4 months ago (2012-08-03 15:46:11 UTC) #1

sky

LGTM https://chromiumcodereview.appspot.com/10830158/diff/5002/chrome/browser/ui/window_snapshot/window_snapshot.h File chrome/browser/ui/window_snapshot/window_snapshot.h (right): https://chromiumcodereview.appspot.com/10830158/diff/5002/chrome/browser/ui/window_snapshot/window_snapshot.h#newcode37 chrome/browser/ui/window_snapshot/window_snapshot.h:37: bool GrabWindowSnapshot( move this into an internal namespace ...

8 years, 4 months ago (2012-08-03 17:24:59 UTC) #2

grt (UTC plus 2)

lgtm w/ removal of redundant declaration. i'll be oof for the next week or so. ...

8 years, 4 months ago (2012-08-03 20:50:45 UTC) #3

qfel

https://chromiumcodereview.appspot.com/10830158/diff/5002/chrome/browser/ui/window_snapshot/window_snapshot.cc File chrome/browser/ui/window_snapshot/window_snapshot.cc (right): https://chromiumcodereview.appspot.com/10830158/diff/5002/chrome/browser/ui/window_snapshot/window_snapshot.cc#newcode15 chrome/browser/ui/window_snapshot/window_snapshot.cc:15: bool GrabWindowSnapshot(gfx::NativeWindow window, On 2012/08/03 20:50:45, grt wrote: > ...

8 years, 4 months ago (2012-08-06 08:49:10 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qfel@google.com/10830158/11001

8 years, 4 months ago (2012-08-06 09:27:51 UTC) #5

commit-bot: I haz the power

Try job failure for 10830158-11001 (retry) on win_rel for step "compile" (clobber build). It's a ...

8 years, 4 months ago (2012-08-06 09:44:53 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qfel@google.com/10830158/5004

8 years, 4 months ago (2012-08-06 10:08:07 UTC) #7

Change committed as 150085

Expand Messages | Collapse Messages