Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6880)

Unified Diff: chrome/browser/ui/window_snapshot/window_snapshot.h

Issue 10830158: Refactor GrabWindowSnapshot and GrabWindowSnapshotImpl names to GrabWindowSnapshotForUser and GrabW… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixed compiling tests, fixed indent Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/feedback_ui.cc ('k') | chrome/browser/ui/window_snapshot/window_snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/window_snapshot/window_snapshot.h
diff --git a/chrome/browser/ui/window_snapshot/window_snapshot.h b/chrome/browser/ui/window_snapshot/window_snapshot.h
index bad52012aefd21c6f7ae39856540e8154468b70a..f4f6f893c65e0dba69f7bf01eaaea9e9f815f3a5 100644
--- a/chrome/browser/ui/window_snapshot/window_snapshot.h
+++ b/chrome/browser/ui/window_snapshot/window_snapshot.h
@@ -17,17 +17,33 @@ class Rect;
namespace chrome {
+void RegisterScreenshotPrefs(PrefService* service);
+
// Grabs a snapshot of the rectangle area |snapshot_bounds| with respect to the
// top left corner of the designated window and stores a PNG representation
// into a byte vector. On Windows, |window| may be NULL to grab a snapshot of
-// the primary monitor. Returns true if the operation is successful.
-bool GrabWindowSnapshot(
+// the primary monitor. This takes into account calling user context (ie. checks
+// policy settings if taking screenshots is allowed), and is intended to be used
+// by browser code. If you need to take a screenshot for debugging purposes,
+// consider using GrabWindowSnapshot.
+// Returns true if the operation is successful (ie. permitted).
+bool GrabWindowSnapshotForUser(
gfx::NativeWindow window,
std::vector<unsigned char>* png_representation,
const gfx::Rect& snapshot_bounds);
-void RegisterScreenshotPrefs(PrefService* service);
+namespace internal {
+
+// Like GrabWindowSnapshotForUser, but does not perform additional security
+// checks - just grabs a snapshot. This is intended to be used for debugging
+// purposes where no BrowserProcess instance is available (ie. tests).
+// DO NOT use in a result of user action.
+bool GrabWindowSnapshot(
+ gfx::NativeWindow window,
+ std::vector<unsigned char>* png_representation,
+ const gfx::Rect& snapshot_bounds);
+} // namespace internal
} // namespace chrome
#endif // CHROME_BROWSER_UI_WINDOW_SNAPSHOT_WINDOW_SNAPSHOT_H_
« no previous file with comments | « chrome/browser/ui/webui/feedback_ui.cc ('k') | chrome/browser/ui/window_snapshot/window_snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698