Issue 10830135: Revert 149604 - Support calling GrabWindowSnapshot when no BrowserProcess instance is avaliable (eg…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830135: Revert 149604 - Support calling GrabWindowSnapshot when no BrowserProcess instance is avaliable (eg… (Closed)

Created:
8 years, 4 months ago by Joao da Silva

Modified:
8 years, 4 months ago

Reviewers:
qfel

CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 149604 - Support calling GrabWindowSnapshot when no BrowserProcess instance is avaliable (eg. tests) BUG=139694 Review URL: https://chromiumcodereview.appspot.com/10821104 TBR=qfel@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149606

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -388 lines)			Patch
M	chrome/browser/ui/window_snapshot/window_snapshot.h	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	chrome/browser/ui/window_snapshot/window_snapshot.cc	View	1 chunk	+7 lines, -2 lines	0 comments	Download
A +	chrome/browser/ui/window_snapshot/window_snapshot_aura.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/window_snapshot/window_snapshot_gtk.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/window_snapshot/window_snapshot_mac.mm	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/window_snapshot/window_snapshot_mac_unittest.mm	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/window_snapshot/window_snapshot_win.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/test/base/ui_test_utils_win.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome_frame/test/test_with_web_server.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	ui/ui.gyp	View	2 chunks	+0 lines, -5 lines	0 comments	Download
D	ui/window_snapshot/window_snapshot.h	View	1 chunk	+0 lines, -34 lines	0 comments	Download
D	ui/window_snapshot/window_snapshot_aura.cc	View	1 chunk	+0 lines, -51 lines	0 comments	Download
D	ui/window_snapshot/window_snapshot_gtk.cc	View	1 chunk	+0 lines, -78 lines	0 comments	Download
D	ui/window_snapshot/window_snapshot_mac.mm	View	1 chunk	+0 lines, -61 lines	0 comments	Download
D	ui/window_snapshot/window_snapshot_mac_unittest.mm	View	1 chunk	+0 lines, -49 lines	0 comments	Download
D	ui/window_snapshot/window_snapshot_win.cc	View	1 chunk	+0 lines, -100 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages