Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Unified Diff: chrome/chrome.gyp

Issue 10830126: Do not pass -dead_strip to ld for the Mac helper and main apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_exe.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome.gyp
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp
index 860a1ddcfa06b9edd1fab0b1c4d2c8e7902d486b..73a630d50b22d42085effc35732680b0666364af 100644
--- a/chrome/chrome.gyp
+++ b/chrome/chrome.gyp
@@ -420,6 +420,16 @@
'CHROMIUM_STRIP_SAVE_FILE': 'app/app.saves',
'INFOPLIST_FILE': 'app/helper-Info.plist',
},
+ # Turn off -dead_strip in Release mode for the main app. There's
+ # little here to strip, and doing so preserves symbols from
+ # crt1.10.6.o, which get removed incorrectly. http://crbug.com/139902
+ 'configurations': {
+ 'Release': {
+ 'xcode_settings': {
+ 'DEAD_CODE_STRIPPING': 'NO',
+ },
+ },
+ },
'postbuilds': [
{
# The helper doesn't have real localizations, it just has
« no previous file with comments | « no previous file | chrome/chrome_exe.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698