Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3988)

Unified Diff: chrome/chrome_exe.gypi

Issue 10830126: Do not pass -dead_strip to ld for the Mac helper and main apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_exe.gypi
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi
index c34c2afe2ac12b99f99f425ac6ad530af7a1e362..c9d15fe0198fa9053a2d6602f91fc09fe15aaf11 100644
--- a/chrome/chrome_exe.gypi
+++ b/chrome/chrome_exe.gypi
@@ -247,6 +247,16 @@
'CHROMIUM_CREATOR': '<(mac_creator)',
'CHROMIUM_SHORT_NAME': '<(branding)',
},
+ # Turn off -dead_strip in Release mode for the main app. There's
+ # little here to strip, and doing so preserves symbols from
+ # crt1.10.6.o, which get removed incorrectly. http://crbug.com/139902
+ 'configurations': {
+ 'Release': {
+ 'xcode_settings': {
+ 'DEAD_CODE_STRIPPING': 'NO',
+ },
+ },
+ },
'dependencies': [
'helper_app',
'infoplist_strings_tool',
« no previous file with comments | « chrome/chrome.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698