Issue 10830126: Do not pass -dead_strip to ld for the Mac helper and main apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830126: Do not pass -dead_strip to ld for the Mac helper and main apps. (Closed)

Created:
8 years, 4 months ago by Robert Sesek

Modified:
8 years, 4 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, Nico

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Do not pass -dead_strip to ld for the Mac helper and main apps. On certain SDK versions and OSes with the 10.6 deployment target, the linker, if invoked with -dead_strip, incorrectly removes _NXArgc and _NXArgv. Since the apps are just shims into the Framework, there's little to strip anyways. BUG=139902 TEST=Build on 10.7+ with GYP variable mac_strip_release=1. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149531

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	M	chrome/chrome.gyp	View		1 chunk	+10 lines, -0 lines	0 comments	Download
	M	chrome/chrome_exe.gypi	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Please measure the code size impact.

KIDDING!

Expand Messages | Collapse Messages