Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1404)

Issue 10830101: Cleanup: Fix a few compiler warnings by changing EXPECT_EQ(false, ...) to EXPECT_FALSE(...). (Closed)

Created:
8 years, 4 months ago by Lei Zhang
Modified:
8 years, 4 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, penghuang+watch_chromium.org, James Su
Visibility:
Public.

Description

Cleanup: Fix some style nits. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149456

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M ui/base/ime/input_method_ibus_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/view_unittest.cc View 1 8 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
And fix some lint errors too...
8 years, 4 months ago (2012-07-31 18:34:59 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-08-01 15:38:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10830101/1
8 years, 4 months ago (2012-08-01 17:28:45 UTC) #3
commit-bot: I haz the power
Failed to apply patch for ui/aura/window_unittest.cc: While running patch -p0 --forward --force; patching file ui/aura/window_unittest.cc ...
8 years, 4 months ago (2012-08-01 17:28:47 UTC) #4
Lei Zhang
On 2012/08/01 17:28:47, I haz the power (commit-bot) wrote: > Hunk #1 FAILED at 1768. ...
8 years, 4 months ago (2012-08-01 17:33:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10830101/6001
8 years, 4 months ago (2012-08-01 17:34:42 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 19:11:15 UTC) #7
Change committed as 149456

Powered by Google App Engine
This is Rietveld 408576698