Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 10824064: Use EXPECT_FALSE instead of EXPECT_EQ to avoid compiler error (Closed)

Created:
8 years, 4 months ago by Hongbo Min
Modified:
8 years, 4 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, penghuang+watch_chromium.org, James Su
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Use EXPECT_FALSE instead to avoid compiler error BUG=139326 TEST=aura_unittests and views_unittests compile and run Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149356

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/aura/window_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/input_method_ibus_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Hongbo Min
8 years, 4 months ago (2012-07-27 13:57:37 UTC) #1
Hongbo Min
On 2012/07/27 13:57:37, Hongbo wrote: Pls review it. Thanks.
8 years, 4 months ago (2012-07-31 09:15:58 UTC) #2
kochi
lgtm
8 years, 4 months ago (2012-07-31 09:29:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hongbo.min@intel.com/10824064/1
8 years, 4 months ago (2012-07-31 15:00:01 UTC) #4
commit-bot: I haz the power
Presubmit check for 10824064-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-31 15:00:06 UTC) #5
Hongbo Min
Ben and Sato, Need your lgtm to commit this fix. Thanks.
8 years, 4 months ago (2012-07-31 15:05:16 UTC) #6
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-07-31 15:53:58 UTC) #7
Yusuke Sato
lgtm
8 years, 4 months ago (2012-07-31 19:29:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hongbo.min@intel.com/10824064/1
8 years, 4 months ago (2012-08-01 00:34:35 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 02:31:13 UTC) #10
Change committed as 149356

Powered by Google App Engine
This is Rietveld 408576698