Allow "cross-compiling" with GRIT

Allow "cross-compiling" with GRIT

This adds an explicit "platform" option to repack_locales.py, so
resources for one platform (e.g. Android) can be compiled on another
(e.g. Linux).

BUG=136951
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149488

[newt (away), 2012-07-31 01:48:35]

PTAL, tony, thanks!

[tony, 2012-07-31 16:47:00]

https://chromiumcodereview.appspot.com/10830085/diff/1/chrome/tools/build/rep...
File chrome/tools/build/repack_locales.py (right):

https://chromiumcodereview.appspot.com/10830085/diff/1/chrome/tools/build/rep...
chrome/tools/build/repack_locales.py:30: PLATFORM = None
I would call this OS since we call it OS in the gyp files.

https://chromiumcodereview.appspot.com/10830085/diff/1/chrome/tools/build/rep...
chrome/tools/build/repack_locales.py:154: -p platform    The target platform.
(e.g. mac, linux, win and etc.)
Nit: os

https://chromiumcodereview.appspot.com/10830085/diff/1/chrome/tools/build/rep...
chrome/tools/build/repack_locales.py:179: elif o in ('-p'):
Hmm, the use of 'in' here happens to work, but it's weird since it's doing a
substring search.  Not your fault, just pointing it out.

https://chromiumcodereview.appspot.com/10830085/diff/1/chrome/tools/build/rep...
chrome/tools/build/repack_locales.py:183: 
I would probably normalize OS around here.  E.g.,
if not OS:
  if sys.platform == 'darwin':
    OS = 'mac'
  elif sys.platform.startswith('linux'):
    OS = 'linux'
  elif sys.platform in ('cygwin', 'win32'):
    OS = 'win'
  else:
    OS = sys.platform

Then you could simplify the condition in calc_output.

[newt (away), 2012-07-31 21:13:53]

Thanks for the comments.  I've fixed those issues.

One question: do you think I should add the '-p <(OS)' flag to gyp files where
repack_locales happens inside an OS-conditional block?  E.g. in chrome_dll.gypi
we call repack_locales inside an 'OS="mac"' block.

https://chromiumcodereview.appspot.com/10830085/diff/1/chrome/tools/build/rep...
File chrome/tools/build/repack_locales.py (right):

https://chromiumcodereview.appspot.com/10830085/diff/1/chrome/tools/build/rep...
chrome/tools/build/repack_locales.py:30: PLATFORM = None
On 2012/07/31 16:47:00, tony wrote:
> I would call this OS since we call it OS in the gyp files.

Done.

https://chromiumcodereview.appspot.com/10830085/diff/1/chrome/tools/build/rep...
chrome/tools/build/repack_locales.py:154: -p platform    The target platform.
(e.g. mac, linux, win and etc.)
On 2012/07/31 16:47:00, tony wrote:
> Nit: os

Done.

https://chromiumcodereview.appspot.com/10830085/diff/1/chrome/tools/build/rep...
chrome/tools/build/repack_locales.py:179: elif o in ('-p'):
On 2012/07/31 16:47:00, tony wrote:
> Hmm, the use of 'in' here happens to work, but it's weird since it's doing a
> substring search.  Not your fault, just pointing it out.

I figured I might as well fix these.

https://chromiumcodereview.appspot.com/10830085/diff/1/chrome/tools/build/rep...
chrome/tools/build/repack_locales.py:183: 
On 2012/07/31 16:47:00, tony wrote:
> I would probably normalize OS around here.  E.g.,
> if not OS:
>   if sys.platform == 'darwin':
>     OS = 'mac'
>   elif sys.platform.startswith('linux'):
>     OS = 'linux'
>   elif sys.platform in ('cygwin', 'win32'):
>     OS = 'win'
>   else:
>     OS = sys.platform
> 
> Then you could simplify the condition in calc_output.

Done.  This is much cleaner.

[tony, 2012-07-31 21:29:04]

On 2012/07/31 21:13:53, newt wrote:
> One question: do you think I should add the '-p <(OS)' flag to gyp files where
> repack_locales happens inside an OS-conditional block?  E.g. in
chrome_dll.gypi
> we call repack_locales inside an 'OS="mac"' block.

Yes, we probably should just for consistency.

LGTM!

[newt (away), 2012-07-31 21:43:05]

Ok, added the flag to all call sites of repack_locales.py.  Thanks, Tony!

[tony, 2012-07-31 21:47:20]

LGTM

[Ben Goodger (Google), 2012-08-01 15:40:31]

lgtm

[commit-bot: I haz the power, 2012-08-01 18:02:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/newt@chromium.org/10830085/9001

[commit-bot: I haz the power, 2012-08-01 18:02:46]

Presubmit check for 10830085-9001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  chrome/tools/build/repack_locales.py, line 146, 97 chars

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-08-01 18:12:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/newt@chromium.org/10830085/6

[commit-bot: I haz the power, 2012-08-01 20:53:47]

Change committed as 149488